Fix failing shibboleth test

This change attempts to resolve the following error:

```
  1) Email Confirmation A user attempts to sign in via the "Sign in with your institutional credentials"
            button. The email is linked to a user account, however the account is
            unconfirmed and has no confirmation token.
     Failure/Error: raise ActionNotFound.new("The action '#{action}' could not be found for #{self.class.name}", self, action)

     AbstractController::ActionNotFound:
       The action 'shibboleth' could not be found for Users::OmniauthCallbacksController

```
The Users::OmniauthCallbacksController#shibboleth action is defined dynamically within the controller. Everything is working locally with commit bcc8d1f, but the test is failing when executed as a GitHub Action.
This change attempts to make sure that the Shibboleth identifier_scheme is created before the corresponding dynamical shibboleth action is triggered during test execution.

Author: aaronskiba

spec/factories/identifier_schemes.rb

@@ -27,16 +27,6 @@
       context_count { 1 }
     end
 
-    # Add a trait for Shibboleth
-    trait :shibboleth do
-      name { 'shibboleth' }
-      context { 11 }
-      description { 'Institutional Sign In (Shibboleth)' }
-      logo_url { nil }
-      identifier_prefix { nil }
-      active { true }
-    end
-
     after(:create) do |identifier_scheme, evaluator|
       (0..evaluator.context_count - 1).each do |idx|
         identifier_scheme.update("#{identifier_scheme.all_context[idx]}": true)

spec/features/email_confirmation_spec.rb

@@ -26,34 +26,40 @@
     expect(page).to have_current_path(plans_path)
   end
 
-  scenario 'A user attempts to sign in via the "Sign in with your institutional credentials"
-            button. The email is linked to a user account, however the account is
-            unconfirmed and has no confirmation token.', :js do
-    user = create(:user, :unconfirmed_and_no_confirmation_token)
-    scheme = create(:identifier_scheme, :shibboleth)
-    # Mock the OmniAuth authentication hash for Shibboleth via OmniAuthHelper
-    OmniAuth.config.mock_auth[:shibboleth] = mock_auth_hash(user, scheme)
-    # Create a Shibboleth-related Identifier for the user
-    Identifier.create(identifier_scheme: scheme,
-                      value: OmniAuth.config.mock_auth[:shibboleth].uid,
-                      attrs: OmniAuth.config.mock_auth[:shibboleth],
-                      identifiable: user)
+  describe 'Initial setup for shibboleth sign-in' do
+    before do
+      # Set up the user and identifier scheme
+      @user = create(:user, :unconfirmed_and_no_confirmation_token)
+      @scheme = IdentifierScheme.find_by!(name: 'shibboleth')
+      # Mock OmniAuth authentication hash for Shibboleth via OmniAuthHelper
+      OmniAuth.config.mock_auth[:shibboleth] = mock_auth_hash(@user, @scheme)
 
-    visit root_path
-    # Sign-in attempt #1 (user is unconfirmed and has no confirmation_token)
-    click_link SSO_SIGN_IN_BUTTON_TEXT
-    expectations_for_unconfirmed_user_with_no_confirmation_token_after_sign_in_attempt(user)
+      # Create the identifier for the user
+      Identifier.create(identifier_scheme: @scheme,
+                        value: OmniAuth.config.mock_auth[:shibboleth].uid,
+                        attrs: OmniAuth.config.mock_auth[:shibboleth],
+                        identifiable: @user)
+    end
 
-    visit root_path
-    # Sign-in attempt #2 (user still unconfirmed but has a confirmation_token)
-    click_link SSO_SIGN_IN_BUTTON_TEXT
-    expectations_for_unconfirmed_user_with_confirmation_token_after_sign_in_attempt
+    scenario 'A user attempts to sign in via the "Sign in with your institutional credentials"
+              button. The email is linked to a user account, however the account is
+              unconfirmed and has no confirmation token.', :js do
+      visit root_path
+      # Sign-in attempt #1 (user is unconfirmed and has no confirmation_token)
+      click_link SSO_SIGN_IN_BUTTON_TEXT
+      expectations_for_unconfirmed_user_with_no_confirmation_token_after_sign_in_attempt(@user)
 
-    # Sign-in attempt #3 (user is now confirmed)
-    user.confirm
-    click_link SSO_SIGN_IN_BUTTON_TEXT
-    # The user is signed in
-    expect(page).to have_current_path(plans_path)
+      visit root_path
+      # Sign-in attempt #2 (user still unconfirmed but has a confirmation_token)
+      click_link SSO_SIGN_IN_BUTTON_TEXT
+      expectations_for_unconfirmed_user_with_confirmation_token_after_sign_in_attempt
+
+      # Sign-in attempt #3 (user is now confirmed)
+      @user.confirm
+      click_link SSO_SIGN_IN_BUTTON_TEXT
+      # The user is signed in
+      expect(page).to have_current_path(plans_path)
+    end
   end
 
   scenario 'A user is unconfirmed but has no confirmation token.

spec/support/helpers/omniauth_helper.rb

@@ -6,6 +6,7 @@ module OmniAuthHelper
   # that simulates the authentication data returned by
   # an OmniAuth provider (e.g. Shibboleth).
   def mock_auth_hash(user, scheme)
+    Rails.application.env_config['devise.mapping'] = Devise.mappings[:user]
     Rails.application.env_config['omniauth.auth'] =
       OmniAuth::AuthHash.new({
                                provider: scheme.name,

spec/support/omniauth.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+OmniAuth.config do |config|
+  # Set the OmniAuth test mode to true
+  config.test_mode = true
+  # Set the OmniAuth full host to nil to avoid URL generation issues in tests
+  config.full_host = nil
+end
+
+RSpec.configure do |config|
+  config.before(:each, type: :feature) do
+    # Ensure the 'shibboleth' IdentifierScheme exists before each :feature test.
+    # The dynamic OmniAuth callback method in Users::OmniauthCallbacksController depends
+    # on this scheme, so it must be created first to ensure the callback works during tests.
+    unless IdentifierScheme.exists?(name: 'shibboleth')
+      IdentifierScheme.create(name: 'shibboleth',
+                              context: 11,
+                              description: 'Institutional Sign In (Shibboleth)',
+                              logo_url: nil, identifier_prefix: nil,
+                              active: true)
+    end
+  end
+end