Fix WriteDMX-Bug (Delta)

Bump v0.0.37

Author: patrick-dmxc

ArtNetSharp/ArtNetSharp.csproj

@@ -2,7 +2,7 @@
 	<PropertyGroup>
 		<TargetFrameworks>net6.0;net7.0;net8.0;net9.0</TargetFrameworks>
 		<PackageLicenseFile>LICENSE</PackageLicenseFile>
-		<Version>0.0.36</Version>
+		<Version>0.0.37</Version>
 		<RepositoryUrl>https://github.com/DMXControl/ArtNetSharp</RepositoryUrl>
 		<PackageProjectUrl>$(RepositoryUrl)</PackageProjectUrl>
 		<PackageTags>RDM; ArtNet; E1.20; E1.33; E1.37-1; E1.37-2; E1.37-5; E1.37-7</PackageTags>

ArtNetSharp/Communication/AbstractInstance.cs

@@ -186,16 +186,16 @@ public DMXSendBag(byte[] data, PortAddress portAddress)
                 PortAddress = portAddress;
             }
 
-            internal async void Update(byte[] data, ushort? startindex = null, ushort? count = null)
+            internal async void Update(byte[] data, ushort? destinationIndex = null, ushort? count = null)
             {
                 if (IsDisposed || IsDisposing)
                     return;
 
                 await SemaphoreSlim?.WaitAsync();
                 try
                 {
-                    if ((startindex + count) <= Data.Length)
-                        Array.Copy(data, 0, Data, startindex.Value, count.Value);
+                    if ((destinationIndex + count) <= Data.Length)
+                        Array.Copy(data, 0, Data, destinationIndex.Value, count.Value);
                     else
                         Array.Copy(data, 0, Data, 0, Math.Min(data.Length, Data.Length));
 
@@ -1072,7 +1072,7 @@ public void RemovePortConfig(params PortConfig[] portConfigs)
             }
         }
 
-        public void WriteDMXValues(PortAddress portAddress, byte[] data, ushort? startindex = null, ushort? count = null)
+        public void WriteDMXValues(PortAddress portAddress, byte[] data, ushort? destinationIndex = null, ushort? count = null)
         {
             if (this.IsDisposing || this.IsDisposed)
                 return;
@@ -1081,26 +1081,28 @@ public void WriteDMXValues(PortAddress portAddress, byte[] data, ushort? startin
                 throw new ArgumentOutOfRangeException();
 
             ushort length = (ushort)data.Length;
+            if(count is null)
+                count = length;
 
-            if (startindex > length)
-                throw new ArgumentOutOfRangeException();
+            if (count > length)
+                throw new ArgumentOutOfRangeException($"{nameof(count)} has to be less then {nameof(data)}.{nameof(data.Length)}");
 
 
-            if ((startindex + count) > length)
-                throw new ArgumentOutOfRangeException();
+            if ((destinationIndex + count) > 512)
+                throw new ArgumentOutOfRangeException($"{nameof(destinationIndex)} + {nameof(count)} has to be less then 512");
 
             int _startIndex = 0;
             int _count = length;
-            if (startindex.HasValue)
-                _startIndex = startindex.Value;
+            if (destinationIndex.HasValue)
+                _startIndex = destinationIndex.Value;
             if (count.HasValue)
                 _count = Math.Min(_count, count.Value);
 
 
             try
             {
                 if (sendDMXBuffer.TryGetValue(portAddress, out DMXSendBag bag))
-                    bag.Update(data, startindex, count);
+                    bag.Update(data, destinationIndex, count);
                 else
                 {
                     var newBag = new DMXSendBag(data, portAddress);

ArtNetTests/LoopTests/LoopTest.cs

@@ -287,6 +287,8 @@ public async Task TestSendDMX()
             for (byte b = 0; b <= 10; b++)
                 await doDmxStuff(b);
 
+            instanceTX.WriteDMXValues(portAddress, new byte[] { 0, 1, 2, 3, 4, 5 }, 10, 5);
+
             instanceRX.DMXReceived -= InstanceRX_DMXReceived;
 
             Assert.Multiple(() =>