Replies: 1 comment
-
Hey @jedisct1, what do you think of this? Is it something that can be improved? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I'm using generate-domains-blocklist.py to merge some lists and I found an issue using domains-allowlist.txt file.
We have a legit domain, in this case
example.com
. and there are few bad subdomains, likead.example.com
,malware.example.com
,tracker.example.com
and so on ... all of them blocked by a source merged during the process.Now I add a new source that accidentaly block
example.com
, well, I addexample.com
todomains-allowlist.txt
file and I run the script.Result:
The
list
doesn't containexample.com
,ad.example.com
,malware.example.com
,tracker.example.com
,...
Expected result:
The
list
should containad.example.com
,malware.example.com
,tracker.example.com
,...
but notexample.com
Not a solution:
I can use
allowed-names.txt
and add=example.com
in there. So we start to generate duplicates rules:example.com
for the block and=example.com
for the unlock.But the important thing is that the script remove the subdomains because
example.com
in contained in one of the source merged and thenexample.com
is removed because is contained indomains-allowlist.txt
file and I lose the possibility to block all of them.Solution:
Implement
=
support indomains-allowlist.txt
file and during the process excludeexample.com
domain only without excludingad.example.com
,malware.example.com
,tracker.example.com
,...
anymore.Beta Was this translation helpful? Give feedback.
All reactions