Fix dynamo and s3 endpoint associations

Author: caiovfernandes

vpc-endpoint-dynamodb.tf

@@ -29,10 +29,8 @@ resource "aws_vpc_endpoint" "dynamodb" {
 }
 
 resource "aws_vpc_endpoint_route_table_association" "private_dynamodb" {
-  for_each = var.vpc_endpoint_dynamodb_gateway ? {
-    for idx, subnet in aws_subnet.private : idx => subnet
-  } : {}
-  route_table_id  = var.multi_nat || var.multi_az_private_rtb ? aws_route_table.private[each.keyk].id : aws_route_table.private[0].id
+  count           = var.vpc_endpoint_dynamodb_gateway ? length(aws_subnet.private) : 0
+  route_table_id  = var.multi_nat || var.multi_az_private_rtb ? aws_route_table.private[count.index].id : aws_route_table.private[0].id
   vpc_endpoint_id = aws_vpc_endpoint.dynamodb[0].id
 }
 

vpc-endpoint-s3.tf

@@ -21,10 +21,7 @@ resource "aws_vpc_endpoint" "s3" {
 }
 
 resource "aws_vpc_endpoint_route_table_association" "private" {
-  for_each = var.vpc_endpoint_s3_gateway ? {
-    for idx, subnet in aws_subnet.private : idx => subnet
-  } : {}
-
-  route_table_id  = var.multi_nat || var.multi_az_private_rtb ? aws_route_table.private[each.key].id : aws_route_table.private[0].id
+  count           = var.vpc_endpoint_s3_gateway ? length(aws_subnet.private) : 0
+  route_table_id  = var.multi_nat || var.multi_az_private_rtb ? aws_route_table.private[count.index].id : aws_route_table.private[0].id
   vpc_endpoint_id = aws_vpc_endpoint.s3[0].id
 }