fix name logic

Author: jsalszbrun

_locals.tf

@@ -14,21 +14,18 @@ locals {
   is_linux   = lower(var.vm.os_type) == "linux"
   is_windows = lower(var.vm.os_type) == "windows"
 
-  vm_type_prefix = local.is_linux ? "lnx" : "win"
-  # We use var.name as workload and var.vm.name_suffix as the suffix (usually 001)
-  vm_name_raw    = "vm-${local.vm_type_prefix}-${local.prefix}-${try(var.vm.name_suffix, "001")}"
-  vm_name        = coalesce(try(var.vm.name, null), substr(replace(lower(local.vm_name_raw), "/[^0-9a-z-]/", ""), 0, 64))
+  # Resource names: use var.name directly as the full name
+  vm_name = var.name
 
-  # Windows has 15 char limit; Linux is flexible, but keep consistent.
-  # Truncate to 15 and trim trailing dashes to avoid Azure validation errors.
+  # Windows has 15 char limit; Linux is flexible.
   computer_name = coalesce(try(var.vm.computer_name, null), trim(substr(local.vm_name, 0, 15), "-"))
 
-  nic_name = "nic-${local.vm_type_prefix}-${local.prefix}-${try(var.vm.name_suffix, "001")}"
-  pip_name = "pip-${local.vm_type_prefix}-${local.prefix}-${try(var.vm.name_suffix, "001")}"
+  nic_name = "nic-${local.vm_name}"
+  pip_name = "pip-${local.vm_name}"
 
   os_disk_name = coalesce(
     try(var.vm.os_disk.name, null),
-    "osdisk-${local.vm_type_prefix}-${local.prefix}-${try(var.vm.name_suffix, "001")}"
+    "osdisk-${local.vm_name}"
   )
 
   identity_type = try(var.vm.identity.type, "SystemAssigned")

_variables.tf

@@ -48,7 +48,6 @@ variable "vm" {
     os_type = string # linux | windows
 
     name        = optional(string)
-    name_suffix = optional(string, "001")
 
     size           = string
     admin_username = string

main.tf

@@ -36,7 +36,7 @@ resource "azurerm_managed_disk" "data" {
   for_each = local.data_disks_map
 
   # Default name logic if each.value.name is null
-  name                = coalesce(each.value.name, "disk-${local.vm_type_prefix}-${local.prefix}-lun${each.value.lun}-${try(var.vm.name_suffix, "001")}")
+  name                = coalesce(each.value.name, "disk-${local.vm_name}-lun${each.value.lun}")
   location            = local.rg_loc
   resource_group_name = local.rg_name