Merge pull request #30 from qqqlab/patch-1

DNedic · web-flow · commit facef7c07aa0 · 2026-02-19T20:16:38.000+01:00
mpmc/queue: Fix condition to check push and pop counts
diff --git a/lockfree/mpmc/queue_impl.hpp b/lockfree/mpmc/queue_impl.hpp
@@ -54,7 +54,7 @@ template <typename T, size_t size> bool Queue<T, size>::Push(const T &element) {
         const size_t pop_count =
             _data[index].pop_count.load(std::memory_order_relaxed);
 
-        if (push_count > pop_count) {
+        if (push_count != pop_count) {
             return false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ template <typename T, size_t size> bool Queue<T, size>::Push(const T &element) {`
`54`	`54`	`const size_t pop_count =`
`55`	`55`	`_data[index].pop_count.load(std::memory_order_relaxed);`
`56`	`56`
`57`		`- if (push_count > pop_count) {`
	`57`	`+ if (push_count != pop_count) {`
`58`	`58`	`return false;`
`59`	`59`	`}`
`60`	`60`