Skip to content

Commit 4e81d93

Browse files
authored
Merge pull request #76 from jwillemsen/jwi-whitespace
Removed redundant whitespaces
2 parents 3b5c689 + 199de9d commit 4e81d93

File tree

5 files changed

+36
-104
lines changed

5 files changed

+36
-104
lines changed

XSC/be/CXX/Elements.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -342,14 +342,6 @@ type_name (SemanticGraph::Instance& i, string const& nss)
342342
}
343343
else
344344
{
345-
//@@ I wonder if this is at all necessary now?
346-
//
347-
348-
//if (!scope.empty ()) r += scope + L"::";
349-
350-
//r += fq_name (i.scope ());
351-
//r += L"::";
352-
353345
r += id (i.name ());
354346
}
355347

XSC/be/CXX/Header.cpp

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ namespace
186186
break;
187187
case CPPMODE::CPP11:
188188
case CPPMODE::CPP17:
189-
os << "using " << name << "_container_type = " << container << "< " << type << ">;";
189+
os << "using " << name << "_container_type = " << container << "<" << type << ">;";
190190
break;
191191
}
192192
switch(this->cppmode_)
@@ -237,7 +237,7 @@ namespace
237237
os << "bool " << name << "_p () const;";
238238
os << type << " const& " << id (name) << " () const;";
239239
// os << type << "& " << id (name) << " ();"; // Lets just have one mutator
240-
os << "void " << id (name) << " (" << type << " const& );";
240+
os << "void " << id (name) << " (" << type << " const&);";
241241

242242
//Added for IDREF case
243243
if ((idref_ptr != std::string::npos) && (this->cppmode_ == CPPMODE::CPP03))
@@ -251,13 +251,13 @@ namespace
251251
switch(this->cppmode_)
252252
{
253253
case CPPMODE::CPP03:
254-
os << "typedef XML_XSC_SMART_PTR( " << type << ") " << id (name) << "_auto_ptr_type;";
255-
os << id (name) << "_auto_ptr_type " << id (name) << "_;";
254+
os << "typedef XML_XSC_SMART_PTR( " << type << ") " << id (name) << "_type;";
255+
os << id (name) << "_type " << id (name) << "_;";
256256
break;
257257
case CPPMODE::CPP11:
258258
case CPPMODE::CPP17:
259-
os << "using " << id (name) << "_unique_ptr_type = std::unique_ptr< " << type << ">;";
260-
os << id (name) << "_unique_ptr_type " << id (name) << "_;";
259+
os << "using " << id (name) << "_type = std::unique_ptr<" << type << ">;";
260+
os << id (name) << "_type " << id (name) << "_;";
261261
break;
262262
}
263263
}
@@ -267,7 +267,7 @@ namespace
267267
//
268268
os << type << " const& " << id (name) << " () const;";
269269
// os << type << "& " << id (name) << " ();"; // Lets just have one mutator.
270-
os << "void " << id (name) << " (" << type << " const& );";
270+
os << "void " << id (name) << " (" << type << " const&);";
271271

272272
//Added for IDREF case
273273
if ((idref_ptr != std::string::npos) && (this->cppmode_ == CPPMODE::CPP03))
@@ -282,13 +282,13 @@ namespace
282282
switch(this->cppmode_)
283283
{
284284
case CPPMODE::CPP03:
285-
os << "typedef XML_XSC_SMART_PTR( " << type << ") " << id (name) << "_auto_ptr_type;";
286-
os << id (name) << "_auto_ptr_type " << id (name) << "_;";
285+
os << "typedef XML_XSC_SMART_PTR( " << type << ") " << id (name) << "_type;";
286+
os << id (name) << "_type " << id (name) << "_;";
287287
break;
288288
case CPPMODE::CPP11:
289289
case CPPMODE::CPP17:
290-
os << "using " << id (name) << "_unique_ptr_type = std::unique_ptr< " << type << ">;";
291-
os << id (name) << "_unique_ptr_type " << id (name) << "_;";
290+
os << "using " << id (name) << "_type = std::unique_ptr<" << type << ">;";
291+
os << id (name) << "_type " << id (name) << "_;";
292292
break;
293293
}
294294
}
@@ -339,7 +339,7 @@ namespace
339339
os << "bool " << name << "_p () const;";
340340
os << type << " const& " << id (name) << " () const;";
341341
os << type << "& " << id (name) << " ();";
342-
os << "void " << id (name) << " (" << type << " const& );";
342+
os << "void " << id (name) << " (" << type << " const&);";
343343

344344
//Added for IDREF case
345345
if ((idref_ptr != std::string::npos) && (this->cppmode_ == CPPMODE::CPP03))
@@ -354,21 +354,21 @@ namespace
354354
switch(this->cppmode_)
355355
{
356356
case CPPMODE::CPP03:
357-
os << "typedef XML_XSC_SMART_PTR( " << type << ") " << id (name) << "_auto_ptr_type;";
358-
os << id (name) << "_auto_ptr_type " << id (name) << "_;";
357+
os << "typedef XML_XSC_SMART_PTR( " << type << ") " << id (name) << "_type;";
358+
os << id (name) << "_type " << id (name) << "_;";
359359
break;
360360
case CPPMODE::CPP11:
361361
case CPPMODE::CPP17:
362-
os << "using " << id (name) << "_unique_ptr_type = std::unique_ptr< " << type << ">;";
363-
os << id (name) << "_unique_ptr_type " << id (name) << "_;";
362+
os << "using " << id (name) << "_type = std::unique_ptr<" << type << ">;";
363+
os << id (name) << "_type " << id (name) << "_;";
364364
break;
365365
}
366366
}
367367
else
368368
{
369369
os << type << " const& " << id (name) << " () const;";
370370
os << type << "& " << id (name) << " ();";
371-
os << "void " << id (name) << " (" << type << " const& );";
371+
os << "void " << id (name) << " (" << type << " const&);";
372372

373373
//Added for IDREF case
374374
if ((idref_ptr != std::string::npos) && (this->cppmode_ == CPPMODE::CPP03))
@@ -383,13 +383,13 @@ namespace
383383
switch(this->cppmode_)
384384
{
385385
case CPPMODE::CPP03:
386-
os << "typedef XML_XSC_SMART_PTR( " << type << ") " << id (name) << "_auto_ptr_type;";
387-
os << id (name) << "_auto_ptr_type " << id (name) << "_;";
386+
os << "typedef XML_XSC_SMART_PTR( " << type << ") " << id (name) << "_type;";
387+
os << id (name) << "_type " << id (name) << "_;";
388388
break;
389389
case CPPMODE::CPP11:
390390
case CPPMODE::CPP17:
391-
os << "using " << id (name) << "_unique_ptr_type = std::unique_ptr< " << type << ">;";
392-
os << id (name) << "_unique_ptr_type " << id (name) << "_;";
391+
os << "using " << id (name) << "_type = std::unique_ptr<" << type << ">;";
392+
os << id (name) << "_type " << id (name) << "_;";
393393
break;
394394
}
395395
}

XSC/be/CXX/Inline.cpp

Lines changed: 12 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,12 @@ namespace
124124
switch(this->cppmode_)
125125
{
126126
case CPPMODE::CPP03:
127-
os << id (name) << "_ = " << scope << "::" << id(name) << "_auto_ptr_type (new " << type << " (e));"
127+
os << id (name) << "_ = " << scope << "::" << id(name) << "_type (new " << type << " (e));"
128128
<< id (name) << "_->container (this);";
129129
break;
130130
case CPPMODE::CPP11:
131131
case CPPMODE::CPP17:
132-
os << id (name) << "_ = std::make_unique< " << type << "> (e);";
132+
os << id (name) << "_ = std::make_unique<" << type << "> (e);";
133133
break;
134134
}
135135
os << "}"
@@ -145,14 +145,6 @@ namespace
145145
<< "{"
146146
<< "return *" << id (name) << "_;"
147147
<< "}";
148-
/* Lets just have one mutator
149-
os << i
150-
<< type << "& " << scope << "::" << endl
151-
<< id (name) << " ()"
152-
<< "{"
153-
<< "return *" << id (name) << "_;"
154-
<< "}";
155-
*/
156148
if ((idref_ptr != std::string::npos) && (this->cppmode_ == CPPMODE::CPP03))
157149
{
158150
os << i
@@ -275,7 +267,6 @@ namespace
275267
os << "}";
276268
}
277269

278-
// if (!this->cpp11_)
279270
{
280271
// count_typename
281272
//
@@ -380,11 +371,11 @@ namespace
380371

381372
if (this->cppmode_ != CPPMODE::CPP03)
382373
{
383-
os << id (name) << "_ = std::make_unique< " << type << "> (e);";
374+
os << id (name) << "_ = std::make_unique<" << type << "> (e);";
384375
}
385376
else
386377
{
387-
os << id (name) << "_ = " << scope << "::" << id(name) << "_auto_ptr_type (new " << type << " (e));"
378+
os << id (name) << "_ = " << scope << "::" << id(name) << "_type (new " << type << " (e));"
388379
<< id (name) << "_->container (this);";
389380
}
390381
os << "}"
@@ -460,12 +451,6 @@ namespace
460451
names_.node_traverser (*this);
461452
}
462453

463-
//virtual void
464-
//traverse (SemanticGraph::Type& t)
465-
//{
466-
// os << comma () << type_name (t) << " const& b__";
467-
//}
468-
469454
virtual void
470455
traverse (SemanticGraph::Enumeration& e)
471456
{
@@ -730,12 +715,6 @@ namespace
730715
{
731716
}
732717

733-
//virtual void
734-
//traverse (SemanticGraph::Type&)
735-
//{
736-
// os << "Base (b__)," << endl;
737-
//}
738-
739718
virtual void
740719
traverse (SemanticGraph::Enumeration&)
741720
{
@@ -859,7 +838,7 @@ namespace
859838

860839
if (this->cppmode_ != CPPMODE::CPP03)
861840
{
862-
os << ", " << name << "_ (std::make_unique< " << type << "> (" << name << "__))" << endl;
841+
os << ", " << name << "_ (std::make_unique<" << type << "> (" << name << "__))" << endl;
863842
}
864843
else
865844
{
@@ -891,7 +870,7 @@ namespace
891870

892871
if (this->cppmode_ != CPPMODE::CPP03)
893872
{
894-
os << ", " << name << "_ (std::make_unique< " << type << "> (" << name << "__))" << endl;
873+
os << ", " << name << "_ (std::make_unique<" << type << "> (" << name << "__))" << endl;
895874
}
896875
else
897876
{
@@ -988,7 +967,7 @@ namespace
988967
{
989968
os << ", " << name << "_ ("
990969
<< "s." << name << "_ ? "
991-
<< "std::make_unique< " << type << "> (*s." << name << "_) : " << nullptr_string << ")" << endl;
970+
<< "std::make_unique<" << type << "> (*s." << name << "_) : " << nullptr_string << ")" << endl;
992971
}
993972
else
994973
{
@@ -1003,7 +982,7 @@ namespace
1003982
//
1004983
if (this->cppmode_ != CPPMODE::CPP03)
1005984
{
1006-
os << ", " << name << "_ (std::make_unique< " << type << "> (*s." << name << "_))" << endl;
985+
os << ", " << name << "_ (std::make_unique<" << type << "> (*s." << name << "_))" << endl;
1007986
}
1008987
else
1009988
{
@@ -1040,7 +1019,7 @@ namespace
10401019
{
10411020
os << ", " << name << "_ ("
10421021
<< "s." << name << "_ ? "
1043-
<< "std::make_unique< " << type << "> (*s." << name << "_) : " << nullptr_string << ")" << endl;
1022+
<< "std::make_unique<" << type << "> (*s." << name << "_) : " << nullptr_string << ")" << endl;
10441023
}
10451024
else
10461025
{
@@ -1053,7 +1032,7 @@ namespace
10531032
{
10541033
if (this->cppmode_ != CPPMODE::CPP03)
10551034
{
1056-
os << ", " << name << "_ (std::make_unique< " << type << "> (*s." << name << "_))" << endl;
1035+
os << ", " << name << "_ (std::make_unique<" << type << "> (*s." << name << "_))" << endl;
10571036
}
10581037
else
10591038
{
@@ -1101,22 +1080,6 @@ namespace
11011080
{
11021081
os << id (name) << "_->container (this);";
11031082
}
1104-
else
1105-
{
1106-
//string type (type_name (e));
1107-
1108-
//// sequence
1109-
////
1110-
//if (this->generate_ra_sequences_)
1111-
// os << name << "_.reserve (s." << name << "_.size ());";
1112-
1113-
//os << "{"
1114-
// << "for (" << name << "_const_iterator i (s."
1115-
// << name << "_.begin ());"
1116-
// << "i != s." << name << "_.end ();"
1117-
// << "++i) " << "add_" << name << " (*i);"
1118-
// << "}";
1119-
}
11201083
}
11211084

11221085
virtual void
@@ -1154,14 +1117,6 @@ namespace
11541117
{
11551118
}
11561119

1157-
//virtual void
1158-
//traverse (SemanticGraph::Type&)
1159-
//{
1160-
// os << "static_cast< Base& > (*this) = "
1161-
// << "static_cast< Base const& > (s);"
1162-
// << endl;
1163-
//}
1164-
11651120
virtual void
11661121
traverse (SemanticGraph::Element& e)
11671122
{
@@ -1179,7 +1134,7 @@ namespace
11791134
os << "if (s." << name << "_)" << std::endl
11801135
<< " " << name << " (*(s." << name << "_));"
11811136
<< "else" << std::endl
1182-
<< " " << name << "_.reset (nullptr);"
1137+
<< " " << name << "_.release ();"
11831138
<< endl;
11841139
}
11851140
else
@@ -1207,19 +1162,6 @@ namespace
12071162
//
12081163
os << id(name) << "_ = s." << id(name) << "_;"
12091164
<< std::endl;
1210-
1211-
//os << name << "_.clear ();";
1212-
1213-
//if (this->generate_ra_sequences_)
1214-
// os << name << "_.reserve (s." << name << "_.size ());";
1215-
1216-
//os << "{"
1217-
// << "for (" << name << "_const_iterator i (s."
1218-
// << name << "_.begin ());"
1219-
// << "i != s." << name << "_.end ();"
1220-
// << "++i) " << std::endl
1221-
// << "add_" << name << " (*i);"
1222-
// << "}";
12231165
}
12241166
}
12251167

@@ -1235,7 +1177,7 @@ namespace
12351177
{
12361178
os << "if (s." << name << "_) "
12371179
<< name << " (*(s." << name << "_));"
1238-
<< "else " << name << "_.reset (nullptr);"
1180+
<< "else " << name << "_.release ();"
12391181
<< endl;
12401182
}
12411183
else

XSC/be/CXX/Source.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,11 @@ namespace
8787
//
8888
if (this->cppmode_ != CPPMODE::CPP03)
8989
{
90-
os << id (name) << "_ = std::make_unique< " << type << "> (e);";
90+
os << id (name) << "_ = std::make_unique<" << type << "> (e);";
9191
}
9292
else
9393
{
94-
os << id (name) << "_ = " << scope << "::" << id(name) << "_auto_ptr_type (new " << type << " (e));"
94+
os << id (name) << "_ = " << scope << "::" << id(name) << "_type (new " << type << " (e));"
9595
<< id (name) << "_->container (this);";
9696
}
9797
}
@@ -231,7 +231,7 @@ namespace
231231
}
232232
else
233233
{
234-
os << id (name) << "_ = " << scope << "::" << id(name) << "_auto_ptr_type (new " << type << " (a));"
234+
os << id (name) << "_ = " << scope << "::" << id(name) << "_type (new " << type << " (a));"
235235
<< id (name) << "_->container (this);";
236236
}
237237
}

XSCRT/XSCRT/Elements.hpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ namespace XSCRT
6060
Type&
6161
operator= (Type const&)
6262
{
63-
//@@ I don't need this.
64-
//if (map_.get ()) map_->clear (); // Flush the map.
6563
return *this;
6664
}
6765

0 commit comments

Comments
 (0)