Update github-release.yml

Author: amystamile-usgs

.github/workflows/github-release.yml

@@ -19,9 +19,17 @@ jobs:
           os: [ubuntu-latest, macos-13]
     runs-on: ${{ matrix.os }}
 
+    outputs:
+      isis_version: ${{ steps.set_version.outputs.isis_version }}
+      built_package: ${{ steps.build_release.outputs.built_package }}
+
     steps:
       - uses: actions/checkout@v4
 
+      - name: Set ISIS_VERSION
+        id: set_version
+        run: echo "isis_version=${{ github.event.release.tag_name || github.ref_name }}" >> "$GITHUB_OUTPUT"
+
       - name: Set up Mambaforge
         uses: conda-incubator/setup-miniconda@v3
         with:
@@ -31,7 +39,7 @@ jobs:
 
       - name: Build Release
         env:
-          ISIS_VERSION: ${{ github.event.release.tag_name || github.ref_name }}
+          ISIS_VERSION: ${{ steps.set_version.outputs.isis_version }}
         run: |
           mamba install conda-build anaconda-client
           git fetch origin
@@ -59,13 +67,8 @@ jobs:
 
           BUILT_DIR=$(conda info --base)/conda-bld
           BUILT_PACKAGE=$(find "$BUILT_DIR" -name "isis-${ISIS_VERSION}-*.conda" | head -n1)
-          echo "$BUILT_PACKAGE" > built_package.txt
+          echo "built_package=$BUILT_PACKAGE" >> "$GITHUB_OUTPUT"
 
-      - name: Upload artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: built-package-${{ matrix.os }}
-          path: built_package.txt
   
   test:
     runs-on: ${{ matrix.os }}
@@ -80,7 +83,7 @@ jobs:
           - os: macos-13
             python: "3.12"
     env:
-      ISIS_VERSION: ${{ github.event.release.tag_name || github.ref_name }}
+      ISIS_VERSION: ${{ needs.build.outputs.isis_version }}
 
     steps:
       - name: Set up Miniforge
@@ -91,7 +94,7 @@ jobs:
           activate-environment: isis-test
           use-mamba: true
           mamba-version: "1.5.3"
-          python-version: ${{ matrix.python-version }}
+          python-version: ${{ matrix.python }}
 
       - name: Conda install and test spiceinit
         run: |
@@ -122,15 +125,15 @@ jobs:
     runs-on: ubuntu-latest
     needs: test
     env:
-      ISIS_VERSION: ${{ github.event.release.tag_name || github.ref_name }}
+      ISIS_VERSION: ${{ needs.build.outputs.isis_version }}
     if: |
-      ${{
-        success() &&
-        !contains(env.ISIS_VERSION, '_RC') &&
-        !contains(env.ISIS_VERSION, '_LTS')
-      }}
+      success() &&
+      !contains(needs.build.outputs.isis_version, '_RC') &&
+      !contains(needs.build.outputs.isis_version, '_LTS')
     steps:
       - uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Set up Conda for doc build
         uses: conda-incubator/setup-miniconda@v3
@@ -151,20 +154,20 @@ jobs:
           ninja docs
 
       - name: Set AWS credentials for upload
-        uses: aws-actions/configure-aws-credentials@0e613a0980cbf65ed5b322eb7a1e075d28913a83
+        uses: aws-actions/configure-aws-credentials@v4
         with:
           aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           aws-region: us-west-2
 
       - name: Upload to S3
         run: |
-          cd docs
+          cd /home/runner/work/ISIS3/ISIS3/build/docs
           if [ -d "${ISIS_VERSION}" ]; then
             cd "${ISIS_VERSION}"
             echo "Uploading documentation to S3..."
             aws s3 sync ./ s3://asc-public-docs/isis-site/${ISIS_VERSION}/ --delete
           else
             echo "Error: docs/${ISIS_VERSION} directory not found!"
             exit 1
-          fi
+          fi