fix(mf5to6): issue when converting MODFLOW-2005 SFR2 packages to MODFLOW-6; line_id is included by default as an auxiliary variable, but no line_id column was getting written to the MODFLOW 6 packagedata. Use SFR2 segment number as line_id in this case. Raise an error for any other declared auxiliary variables that aren't included in packagedata.

Author: aleaf

sfrmaker/mf5to6.py

@@ -249,7 +249,12 @@ def _get_packagedata(self):
             for var in aux_variables:
                 if var in self.rd.columns:
                     packagedata[var] = self.rd[var]
-            
+                elif var == 'line_id':  # included by default
+                    # if no line_id column; use SFR2 segment
+                    packagedata[var] = self.rd['iseg']
+                else:
+                    raise ValueError(f"Auxiliary variable {var} not in packagedata!")
+                    
         cols = [c for c in self.cols if c in packagedata.columns]
         return packagedata[cols].sort_values(by='rno')
 

sfrmaker/test/test_mf5to6.py

@@ -6,6 +6,7 @@
 import numpy as np
 import pandas as pd
 import pytest
+import flopy
 import sfrmaker
 
 
@@ -128,3 +129,15 @@ def test_write(shellmound_sfrdata, mf6sfr_instance_SFRdata, outdir, external_fil
             assert os.path.exists(os.path.join(os.path.split(outfile2)[0],
                                             external_files_path,
                                             '{}_packagedata.dat'.format(version)))
+
+
+def test_convert_mf5_to_6(datapath):
+    model = flopy.modflow.Modflow.load('tf_with_sfr.nam', model_ws=datapath / 'tylerforks/tylerforks')
+    mf5to6 = sfrmaker.Mf6SFR(model.sfr)
+    
+    # check that aux columns, including default line_id, are included in packagedata
+    # otherwise MODFLOW 6 with throw an error
+    if 'auxiliary' in mf5to6.options_block:
+        cols = mf5to6.options_block.split('auxiliary')[1].strip().split('\n')[0].split()
+        for col in cols:
+            assert col in mf5to6.packagedata.columns