Skip to content

Commit dba34a6

Browse files
committed
fix(elevations.py::sample_reach_elevations): another geopandas-related error for case of measured elevations supplied in a csv
1 parent 70baf68 commit dba34a6

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

docs/source/config-summary.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ model:
8080
load_only: None
8181
forgive: False
8282
check: True
83+
extra_pkgs: None
8384
# MODFLOW-6 information
8485
# (arguments to flopy.mf6.MFSimulation.get_model):
8586
model_name: None
@@ -93,6 +94,10 @@ dem:
9394
# keyword arguments to sfrmaker.SFRData.sample_reach_elevations:
9495
buffer_distance: 100
9596
smooth: True
97+
elevation_data: None
98+
elevation_data_crs: None
99+
elevation_data_layer: None
100+
elevation_data_errors: raise
96101

97102
inflows:
98103
# Option to add specified inflows

sfrmaker/elevations.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,9 @@ def get_min(x):
327327
x_coords = measured_elevations['x'].astype(float)
328328
y_coords = measured_elevations['y'].astype(float)
329329
measured_elevations['geometry'] = [Point(x, y) for x, y in zip(x_coords, y_coords)]
330-
measured_elevations = gpd.GeoDataFrame(measured_elevations, crs=elevation_data_crs)
330+
measured_elevations = gpd.GeoDataFrame(measured_elevations)
331+
if elevation_data_crs is not None:
332+
measured_elevations.set_crs(elevation_data_crs, allow_override=True)
331333
measured_elevations['elevation'] = measured_elevations['elevation'].astype(float)
332334

333335
if measured_elevations.crs is None:

sfrmaker/test/test_elevations.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ def test_sample_elevations(dem, tylerforks_sfrdata, datapath, method):
3636
pytest.param('df', 26715, [0, 0, 0], 'raise', marks=pytest.mark.xfail),
3737
('gdf', 26715, [692396.7, 5140825.5, 392.], 'raise'),
3838
('gdf', 4326, [-90.497579, 46.395510, 392], 'raise'),
39-
('csv', None, [692396.7, 5140825.5, 392.], 'raise'),
39+
('csv', 26715, [692396.7, 5140825.5, 392.], 'raise'),
40+
('csv', None, [692396.7, 5140825.5, 392.], 'raise'),
4041
('shp', 4326, [-90.497579, 46.395510, 392], 'raise'),
4142
pytest.param('shp', None, [46.395510,-90.497579, 392], 'raise', marks=pytest.mark.xfail),
4243
('gpkg', 26715, [692396.7, 5140825.5, 392.], 'raise'),

0 commit comments

Comments
 (0)