Skip to content

Commit 1a89f09

Browse files
Michael Vasseurvmcj
authored andcommitted
GitHub recommends to not use pull_request_target
See: https://runs-on.com/github-actions/pull-request-vs-pull-request-target/
1 parent 8ee3377 commit 1a89f09

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

.github/workflows/build-contributor-container-PR.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ name: 'Build Contributor container (PR)'
44

55
on:
66
push:
7-
pull_request_target:
7+
pull_request:
88
branches:
99
- main
1010

@@ -13,7 +13,7 @@ jobs:
1313
if: ${{ !(github.repository == 'domjudge/domjudge-packaging' &&
1414
github.ref == 'refs/heads/main') &&
1515
!contains(github.ref, 'gh-readonly-queue') &&
16-
(github.event_name == 'pull_request_target' ||
16+
(github.event_name == 'pull_request' ||
1717
github.event.pull_request.head.repo.full_name != github.repository) }}
1818
runs-on: ubuntu-latest
1919
steps:

.github/workflows/build-domjudge-container-PR.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: 'Build domjudge container (PR)'
22

33
on:
44
push:
5-
pull_request_target:
5+
pull_request:
66
branches:
77
- main
88

@@ -14,7 +14,7 @@ jobs:
1414
if: ${{ !(github.repository == 'domjudge/domjudge-packaging' &&
1515
github.ref == 'refs/heads/main') &&
1616
!contains(github.ref, 'gh-readonly-queue') &&
17-
(github.event_name == 'pull_request_target' ||
17+
(github.event_name == 'pull_request' ||
1818
github.event.pull_request.head.repo.full_name != github.repository) }}
1919
runs-on: ubuntu-latest
2020
steps:

.github/workflows/build-gitlab-container-PR.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: 'Build GitLab CI container (PR)'
22

33
on:
44
push:
5-
pull_request_target:
5+
pull_request:
66
branches:
77
- main
88

@@ -11,7 +11,7 @@ jobs:
1111
if: ${{ !(github.repository == 'domjudge/domjudge-packaging' &&
1212
github.ref == 'refs/heads/main') &&
1313
!contains(github.ref, 'gh-readonly-queue') &&
14-
(github.event_name == 'pull_request_target' ||
14+
(github.event_name == 'pull_request' ||
1515
github.event.pull_request.head.repo.full_name != github.repository) }}
1616
name: PR GitLab image
1717
runs-on: ubuntu-latest

.github/workflows/shellcheck.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ on:
77
pull_request:
88
branches:
99
- main
10-
pull_request_target:
11-
branches:
12-
- main
1310

1411
jobs:
1512
shellcheck:

0 commit comments

Comments
 (0)