Restructure to make it easier to read

Also this is the new preferred ansible style

Author: vmcj

provision-contest/ansible/roles/domjudge_build/handlers/main.yml

@@ -3,4 +3,7 @@
   command: make -C {{ DJ_DIR }} inplace-postinstall-permissions
 
 - name: restart rsyslog
-  service: name=rsyslog enabled=true state=restarted
+  service:
+    name: rsyslog
+    enabled: true
+    state: restarted

provision-contest/ansible/roles/domjudge_checkout/tasks/main.yml

@@ -16,7 +16,12 @@
 - name: Create working copy of the domjudge repo
   become: true
   become_user: domjudge
-  git: repo={{ dj_git_repo }} dest={{ DJ_DIR }} version={{ DJ_BRANCH }} accept_hostkey=yes update=yes
+  git:
+    repo: "{{ dj_git_repo }}"
+    dest: "{{ DJ_DIR }}"
+    version: "{{ DJ_BRANCH }}"
+    accept_hostkey: true
+    update: true
   register: git_working_copy
 
 - name: Check composer dependencies present

provision-contest/ansible/roles/domjudge_user/handlers/main.yml

@@ -1,3 +1,6 @@
 ---
 - name: restart gdm
-  service: name=gdm3 enabled=true state=restarted
+  service:
+    name: gdm3
+    enabled: true
+    state: restarted

provision-contest/ansible/roles/domserver/handlers/main.yml

@@ -1,3 +1,6 @@
 ---
 - name: restart PHP FPM
-  service: name=php7.4-fpm enabled=true state=restarted
+  service:
+    name: php7.4-fpm
+    enabled: true
+    state: restarted

provision-contest/ansible/roles/hosts/tasks/main.yml

@@ -12,4 +12,3 @@
     group: root
     owner: root
     mode: 0644
-

provision-contest/ansible/roles/judgedaemon/tasks/main.yml

@@ -2,11 +2,18 @@
 # These tasks configure the DOMjudge judgedaemon with chroot
 
 - name: create domjudge-run users
-  user: name=domjudge-run-{{ item }} createhome=no home=/nonexistent group=nogroup shell=/bin/false
+  user:
+    name: "domjudge-run-{{ item }}"
+    createhome: false
+    home: /nonexistent
+    group: nogroup
+    shell: /bin/false
   loop: "{{ cpucore }}"
 
 - name: create domjudge-run group
-  group: name=domjudge-run state=present
+  group:
+    name: domjudge-run
+    state: present
 
 - name: create temp package directory
   file:

provision-contest/ansible/roles/keepalived/handlers/main.yml

@@ -1,3 +1,5 @@
 ---
 - name: restart keepalived service
-  service: name=keepalived state=restarted
+  service:
+    name: keepalived
+    state: restarted

provision-contest/ansible/roles/mysql_replication/tasks/main.yml

@@ -23,7 +23,10 @@
   notify: restart mysql
 
 - name: copy script to setup replication
-  template: src=setup-replication.sh.j2 dest=/usr/local/sbin/setup-replication.sh mode=0755
+  template:
+    src: setup-replication.sh.j2
+    dest: /usr/local/sbin/setup-replication.sh
+    mode: 0755
 
 - name: create mysql replication user
   mysql_user:

provision-contest/ansible/roles/mysql_server/handlers/main.yml

@@ -1,3 +1,6 @@
 ---
 - name: restart mysql
-  service: name=mysql enabled=true state=restarted
+  service:
+    name: mysql
+    enabled: true
+    state: restarted

provision-contest/ansible/roles/prometheus_target_web/handlers/main.yml

@@ -1,9 +1,19 @@
 ---
 - name: restart php-exporter
-  service: name=php-fpm-exporter enabled=true state=restarted
+  service:
+    name: php-fpm-exporter
+    enabled: true
+    state: restarted
+    daemon_reload: true
 
 - name: restart nginx-exporter
-  service: name=prometheus-nginx-exporter enabled=true state=restarted
+  service:
+    name: prometheus-nginx-exporter
+    enabled: true
+    state: restarted
 
 - name: restart mysqld-exporter
-  service: name=prometheus-mysqld-exporter enabled=true state=restarted
+  service:
+    name: prometheus-mysqld-exporter
+    enabled: true
+    state: restarted