Restrict clarifications to teams in the contest

When you have shared DOMjudge instance with 2 different contests with teams
limited by categories (or directly assigned) we would still show all known
teams (even teams not in that contest). We now let the DOMjudge service handle
this.

Author: vmcj

webapp/src/Form/Type/JuryClarificationType.php

@@ -44,7 +44,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             $recipientOptions[$this->getTeamLabel($limitToTeam)] = $limitToTeam->getTeamid();
         } else {
             /** @var Team|null $limitToTeam */
-            $teams = $this->em->getRepository(Team::class)->findAll();
+            $teams = $this->dj->getTeamsForContest($this->dj->getCurrentContest());
             foreach ($teams as $team) {
                 $recipientOptions[$this->getTeamLabel($team)] = $team->getTeamid();
             }

webapp/src/Service/DOMJudgeService.php

@@ -1699,4 +1699,20 @@ public function getAllowedLanguagesForContest(?Contest $contest) : array {
             ->getQuery()
             ->getResult();
     }
+
+    /** @return Team[] */
+    public function getTeamsForContest(?Contest $contest) : array {
+        if ($contest && !$contest->isOpenToAllTeams()) {
+            $contestTeams = $contest->getTeams()->toArray();
+            foreach ($contest->getTeamCategories() as $category) {
+                $contestTeams = array_merge($contestTeams, $category->getTeams()->toArray());
+            }
+            return $contestTeams;
+        }
+        return $this->em->createQueryBuilder()
+            ->select('l')
+            ->from(Team::class, 'l')
+            ->getQuery()
+            ->getResult();
+    }
 }