Fix 404s for wrong problemid (internal vs external)

Also fixed the title of a page where we still did p{{id},
with the move to externalid we now display without the p. So made
this consistent.

Author: vmcj

webapp/templates/jury/analysis/languages.html.twig

@@ -62,7 +62,7 @@
                         <i class="fas fa-file-code fa-fw"></i> {{ language.total }} total submission{% if language.total != 1 %}s{% endif %}
                         for {{ language.problems_attempted_count }} problem{% if language.problems_attempted_count != 1 %}s{% endif %}:<br/>
                         {% for problem in problems %}
-                            <a href="{{ path('jury_problem', {'probId': problem.probid}) }}">
+                            <a href="{{ path('jury_problem', {'probId': problem.externalid}) }}">
                                 {{ problem | problemBadge(language.problems_attempted[problem.probid] is not defined) }}
                             </a>
                         {% endfor %}

webapp/templates/jury/problem_testcases.html.twig

@@ -1,7 +1,7 @@
 {% extends "jury/base.html.twig" %}
 {% import "jury/jury_macros.twig" as macros %}
 
-{% block title %}Testcases for p{{ problem.externalid }} - {{ parent() }}{% endblock %}
+{% block title %}Testcases for {{ problem.externalid }} - {{ parent() }}{% endblock %}
 
 {% block extrahead %}
     {{ parent() }}
@@ -73,13 +73,13 @@
                         {% endif %}
                         <td rowspan="2" class="testrank">
                             {% if allowEdit %}
-                                <a href="{{ path('jury_problem_testcase_move', {'probId': problem.probid, 'rank': testcase.rank, 'direction': 'up'}) }}"
+                                <a href="{{ path('jury_problem_testcase_move', {'probId': problem.externalid, 'rank': testcase.rank, 'direction': 'up'}) }}"
                                    title="Move testcase up"><i class="fas fa-arrow-up"></i></a><br>
                             {% endif %}
                             {{ testcase.rank }}
                             {% if allowEdit %}
                                 <br>
-                                <a href="{{ path('jury_problem_testcase_move', {'probId': problem.probid, 'rank': testcase.rank, 'direction': 'down'}) }}"
+                                <a href="{{ path('jury_problem_testcase_move', {'probId': problem.externalid, 'rank': testcase.rank, 'direction': 'down'}) }}"
                                    title="Move testcase down"><i class="fas fa-arrow-down"></i></a>
                             {% endif %}
                         </td>
@@ -88,7 +88,7 @@
                                    {% if testcase.sample %}checked{% endif %} />
                         </td>
                         <td class="filename">
-                            <a href="{{ path('jury_problem_testcase_fetch', {'probId': problem.probid, 'rank': testcase.rank, 'type': 'input'}) }}">
+                            <a href="{{ path('jury_problem_testcase_fetch', {'probId': problem.externalid, 'rank': testcase.rank, 'type': 'input'}) }}">
                                 {{ testcase.downloadName | split('/') | last }}.{{ extensionMapping.input }}
                             </a>
                         </td>
@@ -114,7 +114,7 @@
                     </tr>
                     <tr>
                         <td class="filename">
-                            <a href="{{ path('jury_problem_testcase_fetch', {'probId': problem.probid, 'rank': testcase.rank, 'type': 'output'}) }}">
+                            <a href="{{ path('jury_problem_testcase_fetch', {'probId': problem.externalid, 'rank': testcase.rank, 'type': 'output'}) }}">
                                 {{ testcase.downloadName | split('/') | last }}.{{ extensionMapping.output }}
                             </a>
                         </td>
@@ -132,8 +132,8 @@
                         {% endif %}
                         <td class="testimage">
                             {% if row.imageSize > 0 %}
-                                <a href="{{ path('jury_problem_testcase_fetch', {'probId': problem.probid, 'rank': testcase.rank, 'type': 'image'}) }}">
-                                    <span class="filename">p{{ problem.probid }}.t{{ testcase.rank }}.{{ testcase.imageType }}</span>
+                                <a href="{{ path('jury_problem_testcase_fetch', {'probId': problem.externalid, 'rank': testcase.rank, 'type': 'image'}) }}">
+                                    <span class="filename">{{ problem.externalid }}.t{{ testcase.rank }}.{{ testcase.imageType }}</span>
                                 </a>
                                 {% if allowEdit %}
                                 &nbsp;