Skip to content

Commit 136028a

Browse files
author
Michael Vasseur
committed
Fail when downloading/verifying the debug script fails
In the past we would continue but crashing is probably the better option as this would either indicate connection errors between domserver & judgehost or even a problem on the judgehost itself.
1 parent 43a0454 commit 136028a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

judge/judgedaemon.main.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -839,8 +839,8 @@ function fetch_executable_internal(
839839
$run_config['hash']
840840
);
841841
if (isset($error)) {
842-
// FIXME
843-
continue;
842+
$scriptId = $judgeTask['run_script_id'];
843+
error("Retrieving/storing debug script '$scriptId' failed.");
844844
}
845845

846846
$debug_cmd = implode(' ', array_map('dj_escapeshellarg',

0 commit comments

Comments
 (0)