Verify that timestrings can be parsed

In case of "unknown" timezones we would silently set the starttime to 0
but leave the startTimeString so the user would not be aware that the
starttime is set to a completely different value.

Author: vmcj

webapp/src/Entity/Contest.php

@@ -1260,6 +1260,17 @@ public function getFreezeData(): FreezeData
         return new FreezeData($this);
     }
 
+    public function checkValidTimeString(string $timeString): bool {
+        if (preg_match("/^[+-]?\d+:\d\d(:\d\d(\.\d{1,6})?)?$/", $timeString) !== 1) {
+            try {
+                $date = new DateTime($timeString);
+            } catch (Exception) {
+                return false;
+            }
+        }
+        return true;
+    }
+
     #[ORM\PrePersist]
     #[ORM\PreUpdate]
     public function updateTimes(): void
@@ -1272,6 +1283,16 @@ public function updateTimes(): void
     #[Assert\Callback]
     public function validate(ExecutionContextInterface $context): void
     {
+        foreach (['Activate', 'Deactivate', 'Start', 'End', 'Freeze', 'Unfreeze'] as $timeString) {
+            $tmpValue = $this->{'get' . $timeString . 'timeString'}();
+            if ($tmpValue === null) continue;
+            if (!$this->checkValidTimeString($tmpValue)) {
+                $context
+                    ->buildViolation("Can't parse this time.")
+                    ->atPath(strtolower($timeString) . "timeString")
+                    ->addViolation();
+            }
+        };
         $this->updateTimes();
         if (Utils::difftime((float)$this->getEndtime(), (float)$this->getStarttime(true)) <= 0) {
             $context