Do not use Doctrine in the migrations.

This would break when adding fields.

(cherry picked from commit 9cc324e)

Author: nickygerritsen

webapp/migrations/Version20191031203138.php

@@ -29,17 +29,14 @@ public function getDescription(): string
 
     public function up(Schema $schema): void
     {
-        $em = $this->container->get('doctrine')->getManager();
-        /** @var Language $python2 */
-        $python2 = $em->getRepository(Language::class)->find('py2');
-        /** @var Language $python3 */
-        $python3 = $em->getRepository(Language::class)->find('py3');
-        if ($python2 === null ||
-            $python3 === null ||
-            $python2->getAllowSubmit() ||
-            $python3->getAllowSubmit() ||
-            $python2->getExtensions() !== ['py2', 'py'] ||
-            $python3->getExtensions() !== ['py3']) {
+        $python2 = $this->connection->fetchAssociative('SELECT * FROM language WHERE langid = :py2', ['py2' => 'py2']);
+        $python3 = $this->connection->fetchAssociative('SELECT * FROM language WHERE langid = :py3', ['py3' => 'py3']);
+        if ($python2 === false ||
+            $python3 === false ||
+            $python2['allow_submit'] ||
+            $python3['allow_submit'] ||
+            json_decode($python2['extensions'], true) !== ['py2', 'py'] ||
+            json_decode($python3['extensions'], true) !== ['py3']) {
             return;
         }
 
@@ -49,19 +46,15 @@ public function up(Schema $schema): void
 
     public function down(Schema $schema): void
     {
-        // this down() migration is auto-generated, please modify it to your needs
-        $em = $this->container->get('doctrine')->getManager();
-        /** @var Language $python2 */
-        $python2 = $em->getRepository(Language::class)->find('py2');
-        /** @var Language $python3 */
-        $python3 = $em->getRepository(Language::class)->find('py3');
+        $python2 = $this->connection->fetchAssociative('SELECT * FROM language WHERE langid = :py2', ['py2' => 'py2']);
+        $python3 = $this->connection->fetchAssociative('SELECT * FROM language WHERE langid = :py3', ['py3' => 'py3']);
 
-        if ($python2 === null ||
-            $python3 === null ||
-            $python2->getAllowSubmit() ||
-            $python3->getAllowSubmit() ||
-            $python2->getExtensions() !== ['py2', 'py'] ||
-            $python3->getExtensions() !== ['py3']) {
+        if ($python2 === false ||
+            $python3 === false ||
+            $python2['allow_submit'] ||
+            $python3['allow_submit'] ||
+            json_decode($python2['extensions'], true) !== ['py2'] ||
+            json_decode($python3['extensions'], true) !== ['py3', 'py']) {
             return;
         }
 

webapp/migrations/Version20200131064449.php

@@ -30,10 +30,9 @@ public function up(Schema $schema) : void
         $this->abortIf($this->connection->getDatabasePlatform()->getName() !== 'mysql', 'Migration can only be executed safely on \'mysql\'.');
 
         // Note: can't use ConfigurationService::get on 'registration_category_name' because the specification has been removed from db-config.yaml
-        $em = $this->container->get('doctrine')->getManager();
-        $registrationCategoryNameConfig = $em->getRepository(Configuration::class)->findOneBy(['name' => 'registration_category_name']);
+        $registrationCategoryNameConfig = $this->connection->fetchAssociative('SELECT * FROM configuration WHERE name = :registration_category_name', ['registration_category_name' => 'registration_category_name']);
         if ($registrationCategoryNameConfig) {
-            $registrationCategoryName = $registrationCategoryNameConfig->getValue();
+            $registrationCategoryName = $registrationCategoryNameConfig['value'];
         } else {
             $registrationCategoryName = '';
         }
@@ -53,23 +52,19 @@ public function down(Schema $schema) : void
     {
         $this->abortIf($this->connection->getDatabasePlatform()->getName() !== 'mysql', 'Migration can only be executed safely on \'mysql\'.');
 
-        $em = $this->container->get('doctrine')->getManager();
-        $selfRegistrationCategories = $em->getRepository(TeamCategory::class)->findBy(
-            ['allow_self_registration' => 1],
-            ['sortorder' => 'ASC']
-        );
+        $selfRegistrationCategories = $this->connection->fetchAllAssociative('SELECT * FROM team_category WHERE allow_self_registration = 1 ORDER BY sortorder');
 
         $this->warnIf(
             count($selfRegistrationCategories) > 1,
             sprintf('Team categories for self-registered teams were %s. Only first will be kept.',
                 implode(', ', array_map(function($category) {
-                    return $category->getName();
+                    return $category['name'];
                 }, $selfRegistrationCategories)))
         );
 
         $this->addSql(
             "INSERT INTO configuration (name, value) VALUES ('registration_category_name', :value)",
-            ['value' => empty($selfRegistrationCategories) ? '""' : json_encode($selfRegistrationCategories[0]->getName())]
+            ['value' => empty($selfRegistrationCategories) ? '""' : json_encode($selfRegistrationCategories[0]['name'])]
         );
 
         $this->addSql('ALTER TABLE team_category DROP allow_self_registration');