Every imported judgement must have a submissionID

vmcj · vmcj · commit 6674001d9cae · 2024-02-12T16:11:39.000Z
If we would make edgecases for all situations every field would become
optional.
diff --git a/webapp/src/Service/ExternalContestSourceService.php b/webapp/src/Service/ExternalContestSourceService.php
@@ -1591,7 +1591,7 @@ protected function importJudgement(string $entityType, ?string $eventId, string
         }
 
         // Now check if we have all dependent data.
-        $submissionId = $data['submission_id'] ?? null;
+        $submissionId = $data['submission_id'];
         $submission = $this->em
             ->getRepository(Submission::class)
             ->findOneBy([

Original file line number	Diff line number	Diff line change
`@@ -1591,7 +1591,7 @@ protected function importJudgement(string $entityType, ?string $eventId, string`
`1591`	`1591`	`}`
`1592`	`1592`
`1593`	`1593`	`// Now check if we have all dependent data.`
`1594`		`- $submissionId = $data['submission_id'] ?? null;`
	`1594`	`+ $submissionId = $data['submission_id'];`
`1595`	`1595`	`$submission = $this->em`
`1596`	`1596`	`->getRepository(Submission::class)`
`1597`	`1597`	`->findOneBy([`