Mark transaction as valid use.

tuupke · tuupke · commit 6861dd1b2f53 · 2025-07-05T18:11:14.000+02:00
Tried removing this transaction for the removal of all unneccesary
transactions. It turns out that this is actually a valid usecase that
should be kept.
diff --git a/webapp/src/Controller/BaseController.php b/webapp/src/Controller/BaseController.php
@@ -239,6 +239,9 @@ protected function commitDeleteEntity(object $entity, array $primaryKeyData): vo
         }
 
         // Now actually delete the entity.
+        // This is a great use of a transaction! Order needs to be guaranteed. Normally deletion
+        // succeeds, in cases where it does not, all work executed by the deletion must be restored
+        // to bring the database in an expected and consistent state.
         $this->em->wrapInTransaction(function () use ($entity) {
             if ($entity instanceof Problem) {
                 // Deleting a problem is a special case:

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,9 @@ protected function commitDeleteEntity(object $entity, array $primaryKeyData): vo`
`239`	`239`	`}`
`240`	`240`
`241`	`241`	`// Now actually delete the entity.`
	`242`	`+ // This is a great use of a transaction! Order needs to be guaranteed. Normally deletion`
	`243`	`+ // succeeds, in cases where it does not, all work executed by the deletion must be restored`
	`244`	`+ // to bring the database in an expected and consistent state.`
`242`	`245`	`$this->em->wrapInTransaction(function () use ($entity) {`
`243`	`246`	`if ($entity instanceof Problem) {`
`244`	`247`	`// Deleting a problem is a special case:`