Get rid of negation logic

nickygerritsen · nickygerritsen · commit 928bd9491560 · 2024-07-28T18:27:28.000Z
diff --git a/webapp/src/Service/ImportExportService.php b/webapp/src/Service/ImportExportService.php
@@ -455,8 +455,6 @@ public function getTeamData(): array
     }
 
     /**
-     * Get results data for the given sortorder.
-     *
      * @return ResultRow[]
      */
     public function getResultsData(int $sortOrder, bool $full = false): array
@@ -550,9 +548,10 @@ public function getResultsData(int $sortOrder, bool $full = false): array
                 $rank        = null;
             }
 
-            $groupWinner = null;
             $categoryId  = $teamScore->team->getCategory()->getCategoryid();
-            if (!isset($groupWinners[$categoryId])) {
+            if (isset($groupWinners[$categoryId])) {
+                $groupWinner = null;
+            } else {
                 $groupWinners[$categoryId] = true;
                 $groupWinner               = $teamScore->team->getCategory()->getName();
             }

Original file line number	Diff line number	Diff line change
`@@ -455,8 +455,6 @@ public function getTeamData(): array`
`455`	`455`	`}`
`456`	`456`
`457`	`457`	`/**`
`458`		`- * Get results data for the given sortorder.`
`459`		`- *`
`460`	`458`	`* @return ResultRow[]`
`461`	`459`	`*/`
`462`	`460`	`public function getResultsData(int $sortOrder, bool $full = false): array`
`@@ -550,9 +548,10 @@ public function getResultsData(int $sortOrder, bool $full = false): array`
`550`	`548`	`$rank = null;`
`551`	`549`	`}`
`552`	`550`
`553`		`- $groupWinner = null;`
`554`	`551`	`$categoryId = $teamScore->team->getCategory()->getCategoryid();`
`555`		`- if (!isset($groupWinners[$categoryId])) {`
	`552`	`+ if (isset($groupWinners[$categoryId])) {`
	`553`	`+ $groupWinner = null;`
	`554`	`+ } else {`
`556`	`555`	`$groupWinners[$categoryId] = true;`
`557`	`556`	`$groupWinner = $teamScore->team->getCategory()->getName();`
`558`	`557`	`}`