Skip to content

Commit 98d8387

Browse files
committed
Only create a queue task if a judging exists
1 parent 164d76b commit 98d8387

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

webapp/src/Service/ExternalContestSourceService.php

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1884,13 +1884,19 @@ protected function importRun(Event $event, EventData $data): void
18841884
->getQuery()
18851885
->execute();
18861886

1887-
$queueTask = new QueueTask();
1888-
$queueTask->setJudging($submission->getJudgings()->first())
1889-
->setPriority($priority)
1890-
->setTeam($submission->getTeam())
1891-
->setTeamPriority((int)$submission->getSubmittime())
1892-
->setStartTime(null);
1893-
$this->em->persist($queueTask);
1887+
// We can only create a queue task if the initial import was successful and created a judging.
1888+
$judging = $submission->getJudgings()->first();
1889+
if ($judging) {
1890+
$queueTask = new QueueTask();
1891+
$queueTask->setJudging($submission->getJudgings()->first())
1892+
->setPriority($priority)
1893+
->setTeam($submission->getTeam())
1894+
->setTeamPriority((int)$submission->getSubmittime())
1895+
->setStartTime(null);
1896+
$this->em->persist($queueTask);
1897+
} else {
1898+
$this->logger->warning('Submission %s has no judging!', [$submission->getSubmitid()]);
1899+
}
18941900
}
18951901
}
18961902

0 commit comments

Comments
 (0)