Fix PHPStan issues for /src/Utils/Scoreboard/*

All bundled in one commit to not flood the history, all of these should
be trivial on itself but help PHPStan to detect more issues.

Author: vmcj

phpstan-baseline.neon

@@ -1069,28 +1069,3 @@ parameters:
 			message: "#^Method App\\\\Twig\\\\TwigExtension\\:\\:runDiff\\(\\) has parameter \\$runOutput with no value type specified in iterable type array\\.$#"
 			count: 1
 			path: webapp/src/Twig/TwigExtension.php
-
-		-
-			message: "#^Method App\\\\Utils\\\\Scoreboard\\\\Scoreboard\\:\\:getUsedCategories\\(\\) has parameter \\$limitToTeamIds with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Utils/Scoreboard/Scoreboard.php
-
-		-
-			message: "#^Method App\\\\Utils\\\\Scoreboard\\\\Scoreboard\\:\\:hasCategoryColors\\(\\) has parameter \\$limitToTeamIds with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Utils/Scoreboard/Scoreboard.php
-
-		-
-			message: "#^Method App\\\\Utils\\\\Scoreboard\\\\Scoreboard\\:\\:isBestInCategory\\(\\) has parameter \\$limitToTeamIds with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Utils/Scoreboard/Scoreboard.php
-
-		-
-			message: "#^Property App\\\\Utils\\\\Scoreboard\\\\Scoreboard\\:\\:\\$bestInCategoryData type has no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Utils/Scoreboard/Scoreboard.php
-
-		-
-			message: "#^Method App\\\\Utils\\\\Scoreboard\\\\Summary\\:\\:__construct\\(\\) has parameter \\$problems with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Utils/Scoreboard/Summary.php

webapp/src/Utils/Scoreboard/Scoreboard.php

@@ -22,6 +22,7 @@ class Scoreboard
 
     /** @var TeamScore[] */
     protected array $scores = [];
+    /** @var int[]|null */
     protected ?array $bestInCategoryData = null;
 
     /**
@@ -334,6 +335,8 @@ public function showPoints(): bool
 
     /**
      * Return the used team categories for this scoreboard.
+     *
+     * @param int[] $limitToTeamIds
      * @return TeamCategory[]
      */
     public function getUsedCategories(?array $limitToTeamIds = null): array
@@ -357,6 +360,8 @@ public function getUsedCategories(?array $limitToTeamIds = null): array
 
     /**
      * Return whether this scoreboard has multiple category colors.
+     *
+     * @param int[] $limitToTeamIds
      */
     public function hasCategoryColors(?array $limitToTeamIds = null): bool
     {
@@ -381,6 +386,8 @@ public function hasCategoryColors(?array $limitToTeamIds = null): bool
 
     /**
      * Determine whether this team is the best in the given category
+     *
+     * @param int[] $limitToTeamIds
      */
     public function isBestInCategory(Team $team, ?array $limitToTeamIds = null): bool
     {

webapp/src/Utils/Scoreboard/Summary.php

@@ -2,6 +2,8 @@
 
 namespace App\Utils\Scoreboard;
 
+use App\Entity\ContestProblem;
+
 class Summary
 {
     /** @var int[] */
@@ -16,6 +18,9 @@ class Summary
     /** @var ProblemSummary[] */
     protected array $problems = [];
 
+    /**
+     * @param ContestProblem[] $problems
+     */
     public function __construct(array $problems)
     {
         foreach (array_keys($problems) as $problemId) {