Skip to content

Commit 9c84e0b

Browse files
committed
Revert "Make the summary footer sticky on desktop"
This broke `main` This reverts commit 1da1ff5.
1 parent 0d3c8e2 commit 9c84e0b

File tree

3 files changed

+7
-41
lines changed

3 files changed

+7
-41
lines changed

webapp/public/style_domjudge.css

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -612,18 +612,6 @@ tr.ignore td, td.ignore, span.ignore {
612612
background-color: #05264c;
613613
}
614614

615-
.scoreboard .problem-summary {
616-
text-align: left;
617-
}
618-
619-
.scoreboard .summaryline {
620-
border-top: 2px solid black;
621-
}
622-
623-
.summaryline .problem-summary-title {
624-
font-size:90%;
625-
}
626-
627615
.select_readonly {
628616
background-color: #e9ecef !important;
629617
opacity: 1;
@@ -661,23 +649,4 @@ blockquote {
661649

662650
.right {
663651
text-align: right;
664-
665-
/* Disable the sticky footer on mobile */
666-
@media only screen and (min-width: 600px) {
667-
.scoreheader th {
668-
z-index: 100;
669-
}
670-
671-
.summaryline td {
672-
position: sticky;
673-
bottom: 0;
674-
box-shadow: 0 -1px 0 0 black,
675-
0 1px 0 0 black;
676-
background: var(--background-color);
677-
}
678-
679-
tbody.scoreboard-sortorder-body {
680-
position: relative;
681-
z-index: 50;
682-
}
683652
}

webapp/templates/partials/scoreboard_summary.html.twig

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% if limitToTeamIds is null %}
22
{% if showTeamSubmissions or jury %}
3-
<tr class="summaryline">
3+
<tr style="border-top: 2px solid black;">
44
{% set summaryColspan = 3 %}
55
{% if showAffiliationLogos %}
66
{% set summaryColspan = summaryColspan + 1 %}
@@ -16,32 +16,32 @@
1616
<td></td>
1717
{% for problem in scoreboard.problems %}
1818
{% set summary = scoreboard.summary.problem(problem.probid) %}
19-
<td class="problem-summary">
19+
<td style="text-align: left;">
2020
{% set link = null %}
2121
{% if jury %}
2222
{% set link = path('jury_problem', {'probId': problem.probid}) %}
2323
{% endif %}
2424
<a {% if link %}href="{{ link }}"{% endif %}>
2525
<i class="fas fa-thumbs-up fa-fw"></i>
26-
<span class="submcorrect problem-summary-title" title="number of accepted submissions">
26+
<span class="submcorrect" style="font-size:90%;" title="number of accepted submissions">
2727
{{ summary.numSubmissionsCorrect[sortOrder] ?? 0 }}
2828
</span>
2929
<br/>
3030

3131
<i class="fas fa-thumbs-down fa-fw"></i>
32-
<span class="submreject problem-summary-title" title="number of rejected submissions">
32+
<span class="submreject" style="font-size:90%;" title="number of rejected submissions">
3333
{{ summary.numSubmissions[sortOrder] ?? 0 - summary.numSubmissionsCorrect[sortOrder] ?? 0 }}
3434
</span>
3535
<br/>
3636

3737
<i class="fas fa-question-circle fa-fw"></i>
38-
<span class="submpend problem-summary-title" title="number of pending submissions">
38+
<span class="submpend" style="font-size:90%;" title="number of pending submissions">
3939
{{ summary.numSubmissionsPending[sortOrder] ?? 0 }}
4040
</span>
4141
<br/>
4242

4343
<i class="fas fa-clock fa-fw"></i>
44-
<span class="problem-summary-title" title="first solved">
44+
<span style="font-size:90%;" title="first solved">
4545
{% if summary.bestTimeInMinutes(sortOrder) is not null %}
4646
{{ summary.bestTimeInMinutes(sortOrder) }}min
4747
{% else %}

webapp/templates/partials/scoreboard_table.html.twig

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
{% endif %}
9797
</tr>
9898
</thead>
99-
<tbody class="scoreboard-sortorder-body">
99+
<tbody>
100100
{% set previousSortOrder = -1 %}
101101
{% set previousTeam = null %}
102102
{% set backgroundColors = {"#FFFFFF": 1} %}
@@ -107,8 +107,6 @@
107107
{% if previousSortOrder != -1 %}
108108
{# Output summary of previous sort order #}
109109
{% include 'partials/scoreboard_summary.html.twig' with {sortOrder: previousSortOrder} %}
110-
</tbody>
111-
<tbody class="scoreboard-sortorder-body" style="z-index: {{ 100-score.team.category.sortorder }};">
112110
{% endif %}
113111
{% set classes = classes | merge(['sortorderswitch']) %}
114112
{% set previousSortOrder = score.team.category.sortorder %}
@@ -394,7 +392,6 @@
394392
395393
.cl{{ colorClass }} {
396394
background-color: {{ color }};
397-
background-clip: content-box;
398395
}
399396
400397
{% set cMin = color|hexColorToRGBA(0) %}

0 commit comments

Comments
 (0)