Skip to content

Commit a0dcd3c

Browse files
Michael Vasseurvmcj
authored andcommitted
Remove fixme but list the outstanding bugs
The original bug was fixed but while testing for another PR it shows that getopt doesn't parse options in the normal POSIX expected way.
1 parent a0728be commit a0dcd3c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

judge/judgedaemon.main.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,8 @@ function fetch_executable_internal(
488488
}
489489

490490
$options = getopt("dv:n:hVe:j:t:", ["diskspace-error"]);
491-
// FIXME: getopt doesn't return FALSE on parse failure as documented!
491+
// We can't fully trust the output of getopt, it has outstanding bugs:
492+
// https://bugs.php.net/search.php?cmd=display&search_for=getopt&x=0&y=0
492493
if ($options===false) {
493494
echo "Error: parsing options failed.\n";
494495
usage();

0 commit comments

Comments
 (0)