Minor changes to DTO logic.

Author: nickygerritsen

webapp/src/Controller/API/ProblemController.php

@@ -295,8 +295,7 @@ public function linkProblemAction(
         ContestProblemPut $contestProblemPut,
         Request $request,
         string $id
-    ): Response
-    {
+    ): Response {
         $problem = $this->em->createQueryBuilder()
                             ->from(Problem::class, 'p')
                             ->select('p')

webapp/src/DataTransferObject/AddSubmission.php

@@ -2,7 +2,6 @@
 
 namespace App\DataTransferObject;
 
-
 use Nelmio\ApiDocBundle\Annotation\Model;
 use OpenApi\Attributes as OA;
 use Symfony\Component\Validator\Constraints as Assert;

webapp/src/Service/ImportExportService.php

@@ -647,6 +647,7 @@ protected function importGroupsTsv(array $content, ?string &$message = null): in
      */
     public function importGroupsJson(array $data, ?string &$message = null, ?array &$saved = null): int
     {
+        // TODO: can we have this use the DTO?
         $groupData = [];
         foreach ($data as $group) {
             $groupData[] = [

webapp/tests/Unit/Controller/API/ContestControllerAdminTest.php

@@ -214,6 +214,7 @@ public function provideChangeTimes(): Generator
         // Note that if the first item contains "id", we replace it with the correct ID in the test
 
         // General tests
+        yield [[], 400, ''];
         yield [['dummy' => 'dummy'], 400, "This value should be of type unknown."];
         yield [['id' => 1], 400, 'Missing \"start_time\" or \"scoreboard_thaw_time\" in request.'];
         yield [['id' => 1, 'start_time' => null, 'scoreboard_thaw_time' => date('Y-m-d\TH:i:s', strtotime('+15 seconds'))], 400, 'Setting both \"start_time\" and \"scoreboard_thaw_time\" at the same time is not allowed.'];