Free C-string allocard by strdup after use

eldering · eldering · commit ad1ff026b0c8 · 2025-02-25T22:18:02.000+01:00
This resource leak was found by Coverity scan.
diff --git a/judge/runguard.cc b/judge/runguard.cc
@@ -806,12 +806,14 @@ void setrestrictions()
 
 	/* Set additional environment variables. */
 	for (const auto &tokens : environment_variables) {
-		char *token = strtok(strdup(tokens.c_str()), ";");
+		char *tokens_dup = strdup(tokens.c_str());
+		char *token = strtok(tokens_dup, ";");
 		while (token != nullptr) {
 			verbose("setting environment variable: %s", token);
 			putenv(token);
 			token = strtok(nullptr, ";");
 		}
+		free(tokens_dup);
 	}
 
 	/* Set resource limits: must be root to raise hard limits.

Original file line number	Diff line number	Diff line change
`@@ -806,12 +806,14 @@ void setrestrictions()`
`806`	`806`
`807`	`807`	`/* Set additional environment variables. */`
`808`	`808`	`for (const auto &tokens : environment_variables) {`
`809`		`- char *token = strtok(strdup(tokens.c_str()), ";");`
	`809`	`+ char *tokens_dup = strdup(tokens.c_str());`
	`810`	`+ char *token = strtok(tokens_dup, ";");`
`810`	`811`	`while (token != nullptr) {`
`811`	`812`	`verbose("setting environment variable: %s", token);`
`812`	`813`	`putenv(token);`
`813`	`814`	`token = strtok(nullptr, ";");`
`814`	`815`	`}`
	`816`	`+ free(tokens_dup);`
`815`	`817`	`}`
`816`	`818`
`817`	`819`	`/* Set resource limits: must be root to raise hard limits.`