Fix clarifications for unlinked problems

Closes: #3032

Author: meisterT

webapp/src/Controller/Jury/ClarificationController.php

@@ -193,7 +193,12 @@ public function viewAction(Request $request, int $id): Response
             $clarcontest = $contest->getShortname();
             $data['subjectlink'] = null;
             if ($clar->getProblem()) {
-                $concernssubject = $contest->getCid() . "-" . $clar->getProblem()->getProbid();
+                if ($clar->getContestProblem()) {
+                    $concernssubject = $contest->getCid() . "-" . $clar->getProblem()->getProbid();
+                } else {
+                    // Very special case, this problem is unlinked.
+                    $concernssubject = "";
+                }
                 $data['subjectlink'] = $this->generateUrl('jury_problem', ['probId' => $clar->getProblem()->getProbid()]);
             } elseif ($clar->getCategory()) {
                 $concernssubject = $contest->getCid() . "-" . $clar->getCategory();

webapp/src/Twig/TwigExtension.php

@@ -1179,9 +1179,9 @@ public function fileTypeIcon(string $type): string
         return 'fas fa-file-' . $iconName;
     }
 
-    public function problemBadge(ContestProblem $problem, bool $grayedOut = false): string
+    public function problemBadge(?ContestProblem $problem, bool $grayedOut = false): string
     {
-        $rgb = Utils::convertToHex($problem->getColor() ?? '#ffffff');
+        $rgb = Utils::convertToHex($problem?->getColor() ?? '#ffffff');
         if ($grayedOut || empty($rgb)) {
             $rgb = Utils::convertToHex('whitesmoke');
         }
@@ -1197,7 +1197,7 @@ public function problemBadge(ContestProblem $problem, bool $grayedOut = false):
             $rgb,
             $border,
             $foreground,
-            $problem->getShortname()
+            $problem?->getShortname() ?? '?'
         );
     }