Skip to content

Commit b455297

Browse files
author
Michael Vasseur
committed
Fail when downloading/verifying the debug script fails
In the past we would continue but crashing is probably the better option as this would either indicate connection errors between domserver & judgehost or even a problem on the judgehost itself.
1 parent 0b2d981 commit b455297

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

judge/judgedaemon.main.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -840,8 +840,8 @@ function fetch_executable_internal(
840840
$run_config['hash']
841841
);
842842
if (isset($error)) {
843-
// FIXME
844-
continue;
843+
$scriptId = $judgeTask['run_script_id'];
844+
error("Retrieving/storing debug script '$scriptId' failed.");
845845
}
846846

847847
$debug_cmd = implode(' ', array_map('dj_escapeshellarg',

0 commit comments

Comments
 (0)