Skip to content

Commit b835119

Browse files
Show import errors as shadow differences in menu count.
1 parent 4eeb570 commit b835119

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

webapp/src/Service/DOMJudgeService.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -390,13 +390,12 @@ public function getUpdates(): array
390390
$shadow_difference_count = $this->em->createQueryBuilder()
391391
->from(Submission::class, 's')
392392
->innerJoin('s.external_judgements', 'ej', Join::WITH, 'ej.valid = 1')
393-
->innerJoin('s.judgings', 'j', Join::WITH, 'j.valid = 1')
393+
->leftJoin('s.judgings', 'j', Join::WITH, 'j.valid = 1')
394394
->select('COUNT(s.submitid)')
395395
->andWhere('s.contest = :contest')
396396
->andWhere('s.externalid IS NOT NULL')
397397
->andWhere('ej.result IS NOT NULL')
398-
->andWhere('j.result IS NOT NULL')
399-
->andWhere('ej.result != j.result')
398+
->andWhere('(j.result IS NOT NULL AND ej.result != j.result) OR s.importError IS NOT NULL')
400399
->andWhere('ej.verified = false')
401400
->setParameter('contest', $contest)
402401
->getQuery()

0 commit comments

Comments
 (0)