Update webapp/src/Service/ScoreboardService.php

meisterT · nickygerritsen · web-flow · commit b8ea0e2387a6 · 2025-03-22T11:01:53.000+01:00
Co-authored-by: Nicky Gerritsen &lt;github@accounts.nickygerritsen.nl&gt;
diff --git a/webapp/src/Service/ScoreboardService.php b/webapp/src/Service/ScoreboardService.php
@@ -573,7 +573,7 @@ public static function convertToScoreKeyElement(int|string $value, Order $order
         if (bccomp($value, $ALMOST_INFINITE, scale: self::SCALE) > 0) {
             throw new Exception("Value $value is too large to convert to a score key element.");
         }
-        if ($value[0] === '-') {
+        if (str_starts_with($value, '-')) {
             throw new Exception("No negative values allowed in score key element, got $value.");
         }
 

Original file line number	Diff line number	Diff line change
`@@ -573,7 +573,7 @@ public static function convertToScoreKeyElement(int\|string $value, Order $order`
`573`	`573`	`if (bccomp($value, $ALMOST_INFINITE, scale: self::SCALE) > 0) {`
`574`	`574`	`throw new Exception("Value $value is too large to convert to a score key element.");`
`575`	`575`	`}`
`576`		`- if ($value[0] === '-') {`
	`576`	`+ if (str_starts_with($value, '-')) {`
`577`	`577`	`throw new Exception("No negative values allowed in score key element, got $value.");`
`578`	`578`	`}`
`579`	`579`