When none of pass-fail, scoring is given, add pass-fail as default.

nickygerritsen · nickygerritsen · commit c150e67f8bcd · 2025-05-23T11:48:24.000-04:00
diff --git a/webapp/src/Service/ImportProblemService.php b/webapp/src/Service/ImportProblemService.php
@@ -286,6 +286,11 @@ public function importZippedProblem(
                     $yamlProblemProperties['typesAsString'] = ['pass-fail'];
                 }
 
+                if (!in_array('pass-fail', $yamlProblemProperties['typesAsString']) &&
+                    !in_array('scoring', $yamlProblemProperties['typesAsString'])) {
+                    $yamlProblemProperties['typesAsString'][] = 'pass-fail';
+                }
+
                 if (isset($yamlData['validator_flags'])) {
                     $yamlProblemProperties['special_compare_args'] = $yamlData['validator_flags'];
                 }

Original file line number	Diff line number	Diff line change
`@@ -286,6 +286,11 @@ public function importZippedProblem(`
`286`	`286`	`$yamlProblemProperties['typesAsString'] = ['pass-fail'];`
`287`	`287`	`}`
`288`	`288`
	`289`	`+ if (!in_array('pass-fail', $yamlProblemProperties['typesAsString']) &&`
	`290`	`+ !in_array('scoring', $yamlProblemProperties['typesAsString'])) {`
	`291`	`+ $yamlProblemProperties['typesAsString'][] = 'pass-fail';`
	`292`	`+ }`
	`293`	`+`
`289`	`294`	`if (isset($yamlData['validator_flags'])) {`
`290`	`295`	`$yamlProblemProperties['special_compare_args'] = $yamlData['validator_flags'];`
`291`	`296`	`}`