Fix saving config options in base test.

Prior to this change we were always resetting missing booleans to false
here: https://github.com/DOMjudge/domjudge/blob/98b0b138de4fc7c2330ac957e88d2e9c83792795/webapp/src/Service/ConfigurationService.php#L200

Since in the base test (https://github.com/DOMjudge/domjudge/blob/98b0b138de4fc7c2330ac957e88d2e9c83792795/webapp/tests/Unit/BaseTestCase.php#L325) we change the data source, this also reset all booleans that were true by default in `etc/db-config.yaml`.

Once we move to Symfony forms, we can likely remove this special casing
alltogether.

Author: meisterT

webapp/src/Controller/Jury/ConfigController.php

@@ -66,7 +66,7 @@ public function indexAction(EventLogService $eventLogService, Request $request):
                 }
             }
             $before = $this->config->all();
-            $errors = $this->config->saveChanges($data, $eventLogService, $this->dj, $options);
+            $errors = $this->config->saveChanges($data, $eventLogService, $this->dj, options: $options);
             $after = $this->config->all();
 
             // Compile a list of differences.

webapp/src/Service/ConfigurationService.php

@@ -166,6 +166,7 @@ public function saveChanges(
         array $dataToSet,
         EventLogService $eventLog,
         DOMJudgeService $dj,
+        bool $treatMissingBooleansAsFalse = true,
         ?array &$options = null
     ): array {
         $specs = $this->getConfigSpecification();
@@ -196,7 +197,7 @@ public function saveChanges(
                 $options[$specName] = $optionToSet;
             }
             if (!array_key_exists($specName, $dataToSet)) {
-                if ($spec->type == 'bool') {
+                if ($spec->type == 'bool' && $treatMissingBooleansAsFalse) {
                     // Special-case bool, since checkboxes don't return a
                     // value when unset.
                     $val = false;

webapp/tests/Unit/BaseTestCase.php

@@ -322,6 +322,6 @@ protected function setupDataSource(int $dataSource): void
         $config   = self::getContainer()->get(ConfigurationService::class);
         $eventLog = self::getContainer()->get(EventLogService::class);
         $dj       = self::getContainer()->get(DOMJudgeService::class);
-        $config->saveChanges(['data_source'=>$dataSource], $eventLog, $dj);
+        $config->saveChanges(['data_source'=>$dataSource], $eventLog, $dj, treatMissingBooleansAsFalse: false);
     }
 }