Add ? to nullable non-mixed properties

Author: nickygerritsen

webapp/src/Command/CheckDatabaseConfigurationDefaultValuesCommand.php

@@ -15,7 +15,7 @@
 )]
 class CheckDatabaseConfigurationDefaultValuesCommand extends Command
 {
-    public function __construct(protected readonly ConfigurationService $config, string $name = null)
+    public function __construct(protected readonly ConfigurationService $config, ?string $name = null)
     {
         parent::__construct($name);
     }

webapp/src/Command/ImportEventFeedCommand.php

@@ -43,7 +43,7 @@ public function __construct(
         protected readonly TokenStorageInterface $tokenStorage,
         protected readonly ?Profiler $profiler,
         protected readonly ExternalContestSourceService $sourceService,
-        string $name = null
+        ?string $name = null
     ) {
         parent::__construct($name);
     }

webapp/src/Command/ScoreboardMergeCommand.php

@@ -52,7 +52,7 @@ public function __construct(
         protected readonly RouterInterface $router,
         #[Autowire('%kernel.project_dir%')]
         protected readonly string $projectDir,
-        string $name = null
+        ?string $name = null
     ) {
         parent::__construct($name);
     }

webapp/src/Config/Loader/YamlConfigLoader.php

@@ -15,12 +15,12 @@ class YamlConfigLoader extends FileLoader
     /**
      * @return mixed
      */
-    public function load(mixed $resource, string $type = null)
+    public function load(mixed $resource, ?string $type = null)
     {
         return Yaml::parse(file_get_contents($resource));
     }
 
-    public function supports($resource, string $type = null): bool
+    public function supports($resource, ?string $type = null): bool
     {
         return is_string($resource) &&
             pathinfo($resource, PATHINFO_EXTENSION) === 'yaml';

webapp/src/Controller/API/JudgementTypeController.php

@@ -83,7 +83,7 @@ public function singleAction(Request $request, string $id): JudgementType
      *
      * @return JudgementType[]
      */
-    protected function getJudgementTypes(array $filteredOn = null): array
+    protected function getJudgementTypes(?array $filteredOn = null): array
     {
         $verdicts = $this->dj->getVerdicts(mergeExternal: true);
 

webapp/src/Controller/API/ProblemController.php

@@ -102,6 +102,7 @@ public function addProblemsAction(Request $request): array
         // Note: we read the JSON as YAML, since any JSON is also YAML and this allows us
         // to import files with YAML inside them that match the JSON format
         $data = Yaml::parseFile($file->getRealPath(), Yaml::PARSE_DATETIME);
+        $messages = [];
         if ($this->importExportService->importProblemsData($contest, $data, $ids, $messages)) {
             return $ids;
         }

webapp/src/Controller/Jury/ImportExportController.php

@@ -245,6 +245,7 @@ public function indexAction(Request $request): Response
                 $this->addFlash('danger', "Parse error in YAML/JSON file (" . $file->getClientOriginalName() . "): " . $e->getMessage());
                 return $this->redirectToRoute('jury_import_export');
             }
+            $messages = [];
             if ($this->importExportService->importProblemsData($problemsImportForm->get('contest')->getData(), $data, $ids, $messages)) {
                 $this->addFlash('success',
                     sprintf('The file %s is successfully imported.', $file->getClientOriginalName()));

webapp/src/Entity/Balloon.php

@@ -60,7 +60,7 @@ public function getDone(): bool
         return $this->done;
     }
 
-    public function setSubmission(Submission $submission = null): Balloon
+    public function setSubmission(?Submission $submission = null): Balloon
     {
         $this->submission = $submission;
         return $this;

webapp/src/Entity/ExecutableFile.php

@@ -89,7 +89,7 @@ public function getRank(): int
         return $this->rank;
     }
 
-    public function setImmutableExecutable(ImmutableExecutable $immutableExecutable = null): ExecutableFile
+    public function setImmutableExecutable(?ImmutableExecutable $immutableExecutable = null): ExecutableFile
     {
         $this->immutableExecutable = $immutableExecutable;
         return $this;

webapp/src/Entity/Team.php

@@ -417,7 +417,7 @@ public function setClearPhoto(bool $clearPhoto): Team
         return $this;
     }
 
-    public function setAffiliation(TeamAffiliation $affiliation = null): Team
+    public function setAffiliation(?TeamAffiliation $affiliation = null): Team
     {
         $this->affiliation = $affiliation;
         return $this;