Don't display number of balloons when no contest is active

vmcj · vmcj · commit e8ddc5ee970d · 2024-07-28T15:45:17.000Z
This fixes: https://domjudge.sentry.io/issues/5634564396/?project=6376669&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=14d&stream_index=1 On the main balloonpage we don't display those balloons so it makes sense to also not update the counter in the menu.
diff --git a/webapp/src/Service/DOMJudgeService.php b/webapp/src/Service/DOMJudgeService.php
@@ -419,7 +419,7 @@ public function getUpdates(): array
             }
         }
 
-        if ($this->checkrole('balloon')) {
+        if ($this->checkrole('balloon') && $contest) {
             $balloonsQuery = $this->em->createQueryBuilder()
                 ->select('b.balloonid', 't.name', 't.location', 'p.name AS pname')
                 ->from(Balloon::class, 'b')

Original file line number	Diff line number	Diff line change
`@@ -419,7 +419,7 @@ public function getUpdates(): array`
`419`	`419`	`}`
`420`	`420`	`}`
`421`	`421`
`422`		`- if ($this->checkrole('balloon')) {`
	`422`	`+ if ($this->checkrole('balloon') && $contest) {`
`423`	`423`	`$balloonsQuery = $this->em->createQueryBuilder()`
`424`	`424`	`->select('b.balloonid', 't.name', 't.location', 'p.name AS pname')`
`425`	`425`	`->from(Balloon::class, 'b')`