Skip to content

Commit eae5e82

Browse files
committed
Use Bash for all GitHub Actions CI jobs
We didn't catch an error with an error being eaten away with a piped command. The benefits of being POSIX compliant are slim for the CI jobs. The -o pipefail is added for al scripts (also if they don't use a `|` yet) and where we don't have set -eu yet this is added but not the -x to keep the looks the same.
1 parent 1b1261d commit eae5e82

File tree

8 files changed

+15
-9
lines changed

8 files changed

+15
-9
lines changed

.github/jobs/baseinstall.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/sh
1+
#!/bin/bash
22

33
. .github/jobs/ci_settings.sh
44

@@ -13,7 +13,7 @@ export APP_ENV="${4:-prod}"
1313

1414
MYSQL_ROOT_PASSWORD=${MYSQL_ROOT_PASSWORD:-root}
1515

16-
set -eux
16+
set -euxo pipefail
1717

1818
if [ -z "$phpversion" ]; then
1919
phpversion=$(php -r 'echo PHP_MAJOR_VERSION.".".PHP_MINOR_VERSION."\n";')

.github/jobs/chroot_checks.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ FAILED=0
2020

2121
trap finish EXIT
2222

23+
set -euo pipefail
24+
2325
DIR=$PWD
2426
section_start "Debug info"
2527
lsb_release -a | tee -a "$ARTIFACTS/debug-info"

.github/jobs/composer_setup.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#!/bin/sh
1+
#!/bin/bash
22

3-
set -eux
3+
set -euxo pipefail
44

55
. .github/jobs/ci_settings.sh
66

.github/jobs/configure-checks/setup_configure_image.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#!/bin/sh
1+
#!/bin/bash
22

3-
set -eux
3+
set -euxo pipefail
44

55
distro_id=$(grep "^ID=" /etc/os-release)
66

.github/jobs/fix_pipelinecomponents_image.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#!/bin/sh
1+
#!/bin/bash
22

3-
set -eux
3+
set -euxo pipefail
44

55
echo "Set plugin config for version detection"
66
phpcs --config-set installed_paths /app/vendor/phpcompatibility/php-compatibility

.github/jobs/getapi.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/sh
22

3-
set -eux
3+
set -euxo pipefail
44

55
# Ignore the CLICS API strict mode
66
sudo sed -i "s/'strict'/'ignore-clics'/g" /opt/domjudge/domserver/webapp/src/Controller/API/AbstractRestController.php

.github/jobs/unit-tests.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
. .github/jobs/ci_settings.sh
44

5+
set -euo pipefail
6+
57
DIR="$PWD"
68

79
export version=$1

.github/jobs/webstandard.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
. .github/jobs/ci_settings.sh
44

5+
set -euo pipefail
6+
57
DIR="$PWD"
68

79
if [ "$#" -ne "2" ]; then

0 commit comments

Comments
 (0)