Skip to content

Commit f6315a4

Browse files
committed
Fail integration test on any PHP/Framwork Exception
In the past we only did this for warnings in the prod env but those shouldn't happen regardless of if we run those in `dev`, `test` or `prod`. This hopefully protects future tests where we miss this line.
1 parent 1283864 commit f6315a4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/integration.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,10 @@ jobs:
141141
curl $CURLOPTS http://localhost/domjudge/jury/contests/1/freeze/doNow || true
142142
curl $CURLOPTS http://localhost/domjudge/jury/contests/1/end/doNow || true
143143
curl $CURLOPTS -X POST -d 'finalize_contest[b]=0&finalize_contest[finalizecomment]=gitlab&finalize_contest[finalize]=' http://localhost/domjudge/jury/contests/1/finalize
144-
- name: Verify no errors in prod.log
144+
- name: Verify no errors in symfony {prod,test,dev}.log
145145
shell: bash
146146
run: |
147-
if cat /opt/domjudge/domserver/webapp/var/log/prod.log | egrep '(CRITICAL|ERROR):'; then
147+
if cat /opt/domjudge/domserver/webapp/var/log/*.log | egrep '(CRITICAL|ERROR):'; then
148148
exit 1
149149
fi
150150
- name: Download and perform API check

0 commit comments

Comments
 (0)