Double scrollbar when viewing submission source

[eldering]

When viewing the source (and diff) of a submission, both the whole page and the source frame have a scrollbar. This is really annoying and we should make sure that only one of these has scrollbar by either

1. make the source frame as high as required to show the full source without a scrollbar
2. make the source frame small enough to render on the page without requiring a scrollbar

I think the first option is best as the second would break when you resize the browser window (or you'd have to dynamically scale the source code frame too.

[eldering]

The scrollbars are not really visible in the screenshot, but were definitely there.

[Kevinjil]

I pushed option 1 to https://github.com/Kevinjil/domjudge/tree/adaptive-editor-height. However, I do really not like this solution, as this is not supported by monaco at all and all the nice features do no longer work properly. At this point, if I cannot get a smooth implementation of 2, I'd prefer keeping double scroll bars.

[Kevinjil]

In the source edit page, option 2 is not feasible as there are resubmission details below the source editor.

[vmcj]

In the source edit page, option 2 is not feasible as there are resubmission details below the source editor.

Can you send a screenshot? Maybe we can re-order that part and put it behind a toggle if we don't need it that often.

[Kevinjil]

A bigger issue is probably the multiple editors, as in #3103:

[Kevinjil]

img

A bigger issue is probably the multiple editors, as in #3103: img

Just dropping the idea quickly without working it out, as a reminder that at some point I will have to look into this: instead of showing 1 or more diff editors, I think it might make more sense to show the source of the submission, and optionally select a previous submission to diff against.