From 4d0963522fdb39e947c08843da2c446413e22156 Mon Sep 17 00:00:00 2001
From: Tobias Werth <werth@cs.fau.de>
Date: Sun, 16 Mar 2025 11:29:33 +0100
Subject: [PATCH] Improve RejudgingFirstToSolveFixture.

Instead of using arbitrary submission times in the past way before
contest start, use submission times within the contest duration.
---
 .../Test/RejudgingFirstToSolveFixture.php       | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/webapp/src/DataFixtures/Test/RejudgingFirstToSolveFixture.php b/webapp/src/DataFixtures/Test/RejudgingFirstToSolveFixture.php
index b6022682ad..a5fb6c9f06 100644
--- a/webapp/src/DataFixtures/Test/RejudgingFirstToSolveFixture.php
+++ b/webapp/src/DataFixtures/Test/RejudgingFirstToSolveFixture.php
@@ -22,13 +22,16 @@ public function load(ObjectManager $manager): void
 
         $manager->persist($team2);
 
+        $contest = $manager->getRepository(Contest::class)->findOneBy(['shortname' => 'demo']);
+        // Two submissions, one for each team, the incorrect one before the correct one.
+        // Later, in the test, we will flip the 'wrong-answer' to correct in
+        // order to produce a new first to solve.
         $submissionData = [
-            // team, submittime,            result]
-            [$team1, '2021-01-01 12:34:56', 'correct'],
-            [$team2, '2021-01-01 12:33:56', 'wrong-answer'],
+            // team, submittime,                     result]
+            [$team2, $contest->getStarttime() + 300, 'wrong-answer'],
+            [$team1, $contest->getStarttime() + 400, 'correct'],
         ];
 
-        $contest = $manager->getRepository(Contest::class)->findOneBy(['shortname' => 'demo']);
         $language = $manager->getRepository(Language::class)->find('cpp');
         $problem = $contest->getProblems()->filter(fn(ContestProblem $problem) => $problem->getShortname() === 'A')->first();
 
@@ -39,11 +42,11 @@ public function load(ObjectManager $manager): void
                 ->setContestProblem($problem)
                 ->setLanguage($language)
                 ->setValid(true)
-                ->setSubmittime(Utils::toEpochFloat($submissionItem[1]));
+                ->setSubmittime($submissionItem[1]);
             $judging = (new Judging())
                 ->setContest($contest)
-                ->setStarttime(Utils::toEpochFloat($submissionItem[1]))
-                ->setEndtime(Utils::toEpochFloat($submissionItem[1]) + 5)
+                ->setStarttime($submissionItem[1])
+                ->setEndtime($submissionItem[1] + 5)
                 ->setValid(true)
                 ->setResult($submissionItem[2]);
             $judging->setSubmission($submission);