Only show warning on jury problemset page before contest start. #2980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
approved these changes
Mar 29, 2025
nickygerritsen
approved these changes
Mar 29, 2025
meisterT
force-pushed
the
nowarnafterstart
branch
from
3f79ce2 to
d49279d
Compare
vmcj
reviewed
Mar 30, 2025
| problem_attachment_path: 'jury_attachment_fetch', | ||
| problem_sample_zip_path: 'jury_problem_sample_zip', | ||
| show_jury_warning: true | ||
| show_jury_warning: not current_contest.state or not current_contest.state.started |
There was a problem hiding this comment.
Suggested change
| show_jury_warning: not current_contest.state or not current_contest.state.started | |
| show_jury_warning: not current_contest or not current_contest.state or not current_contest.state.started |
This still failed for when there is no contest active, I wonder if not current_contest or not current_contest.state.started should also be enough. So if any current_contest will also have the state already. Looking at the getState() I think it does. But I think I prefer to protect against this without this extra knowledge and go for the first suggestion.
Suggested change
| show_jury_warning: not current_contest.state or not current_contest.state.started | |
| show_jury_warning: not current_contest or not current_contest.state.started |
There was a problem hiding this comment.
Yeah, I simplified this condition even more.
meisterT
force-pushed
the
nowarnafterstart
branch
from
d49279d to
61e26b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.