diff --git a/webapp/src/Entity/Clarification.php b/webapp/src/Entity/Clarification.php index e848bde630..05c4fb0628 100644 --- a/webapp/src/Entity/Clarification.php +++ b/webapp/src/Entity/Clarification.php @@ -352,6 +352,6 @@ public function getSummary(): string $newBody .= $line . ' '; } } - return Utils::cutString(html_entity_decode((empty($newBody) ? $this->getBody() : $newBody)), 80); + return Utils::cutString(html_entity_decode((empty($newBody) ? $this->getBody() : $newBody)), 120); } } diff --git a/webapp/templates/team/partials/clarification_list.html.twig b/webapp/templates/team/partials/clarification_list.html.twig index daa60a8b53..a8afe67896 100644 --- a/webapp/templates/team/partials/clarification_list.html.twig +++ b/webapp/templates/team/partials/clarification_list.html.twig @@ -4,15 +4,14 @@ {% endif %}
- +
- - {% if includeSubject %} {% endif %} + @@ -26,33 +25,12 @@ {{ clarification.submittime | printtime(null, clarification.contest) }} - {%- if clarification.sender is null %} - {%- set sender = 'Jury' %} - {%- if clarification.recipient is null %} - {%- set recipient = 'All' %} - {%- else %} - {%- set recipient = clarification.recipient.effectiveName %} - {%- endif %} - {%- else %} - {%- set recipient = 'Jury' %} - {%- set sender = clarification.sender.effectiveName %} - {%- endif %} - - {% if includeSubject %} {% endif %} + + diff --git a/webapp/templates/team/partials/submission_list.html.twig b/webapp/templates/team/partials/submission_list.html.twig index 588afb2457..80c4bd2123 100644 --- a/webapp/templates/team/partials/submission_list.html.twig +++ b/webapp/templates/team/partials/submission_list.html.twig @@ -4,7 +4,7 @@ {% if submissions is empty %}
No submissions
{% else %} -
timefromtosubjectto text
- - {{ sender | u.truncate(teamname_max_length, '…') }} - - - - {{ recipient | u.truncate(teamname_max_length, '…') }} - - {%- if clarification.problem -%} - problem {{ clarification.contestProblem | problemBadge -}} + {{ clarification.contestProblem | problemBadge -}} {%- elseif clarification.category -%} {{- categories[clarification.category]|default('general') -}} {%- else -%} @@ -62,9 +40,22 @@ + {%- if clarification.sender is null and clarification.recipient is not null %} + you + {%- else %} + all + {%- endif -%} + - {{ clarification.summary | markdown_to_html | sanitize_html('app.clarification_sanitizer') }} + {{ clarification.summary + | markdown_to_html + | replace({'

': '', '

': ''}) + | sanitize_html('app.clarification_sanitizer') + | raw + }}
+
@@ -30,9 +30,6 @@ {% if not submission.valid %} {% set classes = classes ~ ' ignore' %} {% endif %} - {% if submission.judgings.first is empty or not submission.judgings.first.seen %} - {% set classes = classes ~ ' unseen' %} - {% endif %} diff --git a/webapp/tests/Unit/Controller/Team/ClarificationControllerTest.php b/webapp/tests/Unit/Controller/Team/ClarificationControllerTest.php index 25ef162753..31a31bb9c0 100644 --- a/webapp/tests/Unit/Controller/Team/ClarificationControllerTest.php +++ b/webapp/tests/Unit/Controller/Team/ClarificationControllerTest.php @@ -23,7 +23,7 @@ public function testClarificationRequest(): void $this->verifyRedirectToURL('http://localhost/team'); // Now check if we actually have this clarification. - self::assertSelectorExists('html:contains("problem C")'); + self::assertSelectorExists('html:contains("C")'); self::assertSelectorExists('html:contains("I don\'t understand this problem")'); } } diff --git a/webapp/tests/Unit/Entity/ClarificationTest.php b/webapp/tests/Unit/Entity/ClarificationTest.php index d9d75abeb6..e5b91c59b4 100644 --- a/webapp/tests/Unit/Entity/ClarificationTest.php +++ b/webapp/tests/Unit/Entity/ClarificationTest.php @@ -15,7 +15,7 @@ public function testSummary(): void 'Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua.'; $clarification->setBody($text); - static::assertEquals('Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod …', + static::assertEquals('Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magn…', $clarification->getSummary()); } @@ -50,9 +50,10 @@ public function testMergeNewlines(): void sixth line, seventh line, eighth line, +ninth line, and so on.'; $clarification->setBody($text); - static::assertEquals('First line, second line, third line, fourth line, fifth line, sixth line, sevent…', + static::assertEquals('First line, second line, third line, fourth line, fifth line, sixth line, seventh line, eighth line, ninth line, and so …', $clarification->getSummary()); } }
time
@@ -81,7 +78,7 @@ {% endif %} {% if allowDownload %} - +