Skip to content

Conversation

meisterT
Copy link
Member

No description provided.

@meisterT
Copy link
Member Author

This was previously failing on an unrelated PR: https://github.com/DOMjudge/domjudge/actions/runs/18443423941/job/52546837412?pr=3150

@meisterT meisterT force-pushed the sniff branch 3 times, most recently from 6bda102 to cfdb868 Compare October 12, 2025 12:22
@meisterT
Copy link
Member Author

@nickygerritsen you touched .github/jobs/fix_pipelinecomponents_image.sh last, I tried a couple of fixes to that file but was not able to make it work, composer update didn't help either. You have any clue how to fix it?

@nickygerritsen
Copy link
Member

I think that sed now needs 3.13.3.

@meisterT meisterT force-pushed the sniff branch 2 times, most recently from eadf314 to b52351a Compare October 12, 2025 12:52
@meisterT
Copy link
Member Author

Well, was worth a try, but doesn't work either.

@nickygerritsen
Copy link
Member

Can we cat the composer.json? I think it has 3.13.2 now given this error:

    - phpcompatibility/php-compatibility dev-develop requires squizlabs/php_codesniffer ^3.13.3 || ^4.0 -> found squizlabs/php_codesniffer[3.13.3, 3.13.4, 4.0.0] but it conflicts with your root composer.json require (3.13.2).

Note: this is not OUR composer.json but from the phpcs app.

If this is indeed the issue, we need

sed -i 's/"squizlabs\/php_codesniffer": "3.13.2"/"squizlabs\/php_codesniffer": "^3.13.3"/g' /app/composer.json

@meisterT
Copy link
Member Author

Thanks, that seems to have helped. I am keeping the cat in the fix script to ease future debugging.

@meisterT meisterT enabled auto-merge October 12, 2025 13:38
@meisterT meisterT added this pull request to the merge queue Oct 12, 2025
Merged via the queue into DOMjudge:main with commit 061d77f Oct 12, 2025
36 checks passed
@meisterT meisterT deleted the sniff branch October 12, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants