Skip to content

Commit 9b82266

Browse files
committed
Removes uploader
Change-Id: I484299f2ca76b1861ee64439431b0777541442eb
1 parent 0ef0bfe commit 9b82266

File tree

3 files changed

+0
-168
lines changed

3 files changed

+0
-168
lines changed

megalist_dataflow/main.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
from uploaders.google_ads.customer_match.user_id_uploader import GoogleAdsCustomerMatchUserIdUploaderDoFn
3030
from uploaders.google_ads.conversions.google_ads_offline_conversions_uploader import GoogleAdsOfflineUploaderDoFn
3131
from uploaders.google_ads.conversions.google_ads_ssd_uploader import GoogleAdsSSDUploaderDoFn
32-
from uploaders.google_ads.conversions.google_ads_enhanced_conversions_uploader import GoogleAdsEnhancedConversionsUploaderDoFn
3332
from uploaders.google_analytics.google_analytics_data_import_uploader import GoogleAnalyticsDataImportUploaderDoFn
3433
from uploaders.google_analytics.google_analytics_measurement_protocol import GoogleAnalyticsMeasurementProtocolUploaderDoFn
3534
from uploaders.google_analytics.google_analytics_user_list_uploader import GoogleAnalyticsUserListUploaderDoFn
@@ -59,15 +58,6 @@ def __init__(self, oauth_credentials, dataflow_options=None, hasher=None):
5958
def expand(self, executions):
6059
pass
6160

62-
class GoogleAdsEnhancedConversionsStep(MegalistaStep):
63-
def expand(self, executions):
64-
return (
65-
executions
66-
| 'Load Data - Google Ads Enhanced Conversions' >> BatchesFromExecutions(DestinationType.ADS_ENHANCED_CONVERSION)
67-
| 'Hash Users - Google Ads Enhanced Conversions' >> beam.Map(self._hasher.hash_users)
68-
| 'Upload - Google Ads Enhanced Conversions' >> beam.ParDo(GoogleAdsEnhancedConversionsUploaderDoFn(self._oauth_credentials))
69-
)
70-
7161
class GoogleAdsSSDStep(MegalistaStep):
7262
def expand(self, executions):
7363
return (
@@ -217,7 +207,6 @@ def run(argv=None):
217207
oauth_credentials, dataflow_options)
218208
executions | CampaignManagerConversionStep(oauth_credentials, dataflow_options)
219209
executions | AppsFlyerEventsStep(oauth_credentials, dataflow_options)
220-
executions | GoogleAdsEnhancedConversionsStep(oauth_credentials, dataflow_options, AdsUserListPIIHashingMapper())
221210

222211
# todo: update trix at the end
223212

megalist_dataflow/uploaders/google_ads/conversions/google_ads_enhanced_conversions_uploader.py

Lines changed: 0 additions & 93 deletions
This file was deleted.

megalist_dataflow/uploaders/google_ads/conversions/google_ads_enhanced_conversions_uploader_test.py

Lines changed: 0 additions & 64 deletions
This file was deleted.

0 commit comments

Comments
 (0)