Skip to content

Commit a462916

Browse files
committed
net/mlx5: fix build with MinGW 13
After an upgrade to MinGW version 13, compilation breaks: drivers/net/mlx5/windows/mlx5_ethdev_os.c:285:69: error: 'dev_link.<U1000>.<Uaf00>.link_autoneg' may be used uninitialized This is because link_autoneg is never set in mlx5_link_update(). It can be set to the previous value (no change). Also it does not make sense to check this value to return the update status as it does not change. Fixes: 6fbd737 ("net/mlx5: support link update on Windows") Cc: [email protected] Signed-off-by: Thomas Monjalon <[email protected]> Acked-by: Dariusz Sosnowski <[email protected]> Acked-by: Bruce Richardson <[email protected]>
1 parent d9f66be commit a462916

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/mlx5/windows/mlx5_ethdev_os.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,11 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete)
283283
dev_link.link_duplex = 1;
284284
if (dev->data->dev_link.link_speed != dev_link.link_speed ||
285285
dev->data->dev_link.link_duplex != dev_link.link_duplex ||
286-
dev->data->dev_link.link_autoneg != dev_link.link_autoneg ||
287286
dev->data->dev_link.link_status != dev_link.link_status)
288287
ret = 1;
289288
else
290289
ret = 0;
290+
dev_link.link_autoneg = dev->data->dev_link.link_autoneg;
291291
dev->data->dev_link = dev_link;
292292
return ret;
293293
}

0 commit comments

Comments
 (0)