Skip to content

Commit f93fb07

Browse files
committed
ci: remove node-complexity check
This check does not reflect real performance. Sometimes, adding more instructions in a function can make it faster. Remove it from automated CI verifications. Keep the script since it "may" be useful in some cases. Signed-off-by: Robin Jarry <rjarry@redhat.com> Reviewed-by: Maxime Leroy <maxime@leroys.fr>
1 parent 5ead471 commit f93fb07

File tree

2 files changed

+0
-892
lines changed

2 files changed

+0
-892
lines changed

.github/workflows/check.yml

Lines changed: 0 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -129,58 +129,6 @@ jobs:
129129
path: ${{ env.CCACHE_DIR }}
130130
key: ${{ steps.cache.outputs.cache-primary-key }}
131131

132-
node-complexity:
133-
if: ${{ github.actor != 'grout-bot' }}
134-
permissions:
135-
actions: write
136-
runs-on: ubuntu-24.04
137-
container: fedora:43
138-
env:
139-
DEBIAN_FRONTEND: noninteractive
140-
NEEDRESTART_MODE: l
141-
CC: ccache gcc
142-
BUILDTYPE: debugoptimized
143-
SANITIZE: none
144-
MESON_EXTRA_OPTS: -Ddpdk:cpu_instruction_set=x86-64-v3
145-
steps:
146-
- name: install system dependencies
147-
run: |
148-
set -xe
149-
dnf install -y ccache git gcc make meson ninja-build \
150-
pkgconf python3-pyelftools scdoc libmnl-devel binutils \
151-
libcmocka-devel libedit-devel libevent-devel numactl-devel \
152-
libsmartcols-devel libarchive-devel rdma-core-devel llvm
153-
- uses: actions/checkout@v4
154-
- run: echo "CCACHE_DIR=$(ccache -k cache_dir)" >> $GITHUB_ENV
155-
- uses: actions/cache/restore@v4
156-
id: cache
157-
with:
158-
path: ${{ env.CCACHE_DIR }}
159-
key: ccache-x86_64-gcc-node-complexity
160-
- run: ccache -z
161-
- run: make
162-
- run: devtools/node-complexity --mcpu=x86-64-v3 --compare devtools/complexity.json
163-
- run: ccache -sv
164-
- name: delete old cache
165-
if: ${{ ! github.event.pull_request.commits }}
166-
uses: actions/github-script@v7
167-
with:
168-
script: |
169-
try {
170-
await github.rest.actions.deleteActionsCacheByKey({
171-
owner: context.repo.owner,
172-
repo: context.repo.repo,
173-
key: "${{ steps.cache.outputs.cache-primary-key }}"
174-
});
175-
} catch (error) {
176-
if (error.status !== 404) throw error;
177-
}
178-
- uses: actions/cache/save@v4
179-
if: ${{ ! github.event.pull_request.commits }}
180-
with:
181-
path: ${{ env.CCACHE_DIR }}
182-
key: ${{ steps.cache.outputs.cache-primary-key }}
183-
184132
build-cross-aarch64:
185133
if: ${{ github.actor != 'grout-bot' }}
186134
permissions:

0 commit comments

Comments
 (0)