Merge pull request #542 from DSM-PICK/541-자습-출결-정상화

feat :: finder 삭제

Author: ByunDohwi

src/main/kotlin/dsm/pick2024/domain/attendance/service/QueryClassAllAttendanceService.kt

@@ -3,33 +3,25 @@ package dsm.pick2024.domain.attendance.service
 import dsm.pick2024.domain.attendance.port.`in`.QueryClassAllAttendanceUseCase
 import dsm.pick2024.domain.attendance.port.out.QueryAttendancePort
 import dsm.pick2024.domain.attendance.presentation.dto.response.QueryAllAttendanceResponse
-import dsm.pick2024.domain.classroom.port.`in`.ClassroomFinderUseCase
-import org.springframework.dao.EmptyResultDataAccessException
+import dsm.pick2024.domain.classroom.port.out.QueryClassroomPort
 import org.springframework.stereotype.Service
 import org.springframework.transaction.annotation.Transactional
 
 @Service
 class QueryClassAllAttendanceService(
     private val queryAttendancePort: QueryAttendancePort,
-    private val classroomFinderUseCase: ClassroomFinderUseCase
+    private val queryClassroomPort: QueryClassroomPort
 ) : QueryClassAllAttendanceUseCase {
     @Transactional(readOnly = true)
     override fun queryClassAllAttendance(grade: Int, classNum: Int) =
         queryAttendancePort.findByGradeAndClassNum(grade, classNum)
-            .map { it ->
+            .map {
                 val userId = it.userId
-                val classroomName = try {
-                    val classroom = classroomFinderUseCase.findOKClassroomOrThrow(userId)
-                    classroom.classroomName ?: ""
-                } catch (e: EmptyResultDataAccessException) {
-                    ""
-                }
+                val classroomName = queryClassroomPort.findOKClassroom(userId)?.classroomName ?: ""
 
-                with(it) {
-                    QueryAllAttendanceResponse(
-                        it,
-                        classroomName
-                    )
-                }
+                QueryAllAttendanceResponse(
+                    it,
+                    classroomName
+                )
             }.distinctBy { it.id }.sortedWith(compareBy { it.num })
 }