Merge pull request #4632 from alanorth/modern-node

Use several modern Node.js patterns

Author: tdonohue

.eslintrc.json

@@ -253,6 +253,10 @@
             "forceSingleLine": true
           }
         ],
+        "import/enforce-node-protocol-usage": [
+          "error",
+          "always"
+        ],
 
         "unused-imports/no-unused-imports": "error",
         "lodash/import-scope": [

cypress/plugins/index.ts

@@ -1,4 +1,4 @@
-const fs = require('fs');
+const fs = require('node:fs');
 
 // These two global variables are used to store information about the REST API used
 // by these e2e tests. They are filled out prior to running any tests in the before()

lint/generate-docs.ts

@@ -12,8 +12,8 @@ import {
   readFileSync,
   rmSync,
   writeFileSync,
-} from 'fs';
-import { join } from 'path';
+} from 'node:fs';
+import { join } from 'node:path';
 
 import { default as htmlPlugin } from './src/rules/html';
 import { default as tsPlugin } from './src/rules/ts';

lint/src/util/theme-support.ts

@@ -6,10 +6,11 @@
  * http://www.dspace.org/license/
  */
 
+import { readFileSync } from 'node:fs';
+import { basename } from 'node:path';
+
 import { TSESTree } from '@typescript-eslint/utils';
 import { RuleContext } from '@typescript-eslint/utils/ts-eslint';
-import { readFileSync } from 'fs';
-import { basename } from 'path';
 import ts, { Identifier } from 'typescript';
 
 import {

package-lock.json

@@ -3,10 +3,9 @@
   "version": "10.0.0-next",
   "scripts": {
     "ng": "ng",
-    "config:watch": "nodemon",
     "test:rest": "ts-node --project ./tsconfig.ts-node.json scripts/test-rest.ts",
     "start": "npm run start:prod",
-    "start:dev": "nodemon --exec \"cross-env NODE_ENV=development npm run serve\"",
+    "start:dev": "cross-env NODE_ENV=development npm run serve --watch",
     "start:prod": "npm run build:prod && cross-env NODE_ENV=production npm run serve:ssr",
     "start:mirador:prod": "npm run build:mirador && npm run start:prod",
     "preserve": "npm run base-href",
@@ -19,7 +18,7 @@
     "build:ssr": "ng build --configuration production && ng run dspace-angular:server:production",
     "build:lint": "rimraf 'lint/dist/**/*.js' 'lint/dist/**/*.js.map' && tsc -b lint/tsconfig.json",
     "test": "ng test --source-map=true --watch=false --configuration test",
-    "test:watch": "nodemon --exec \"ng test --source-map=true --watch=true --configuration test\"",
+    "test:watch": "ng test --source-map=true --watch=true --configuration test",
     "test:headless": "ng test --source-map=true --watch=false --configuration test --browsers=ChromeHeadless --code-coverage",
     "test:lint": "npm run build:lint && npm run test:lint:nobuild",
     "test:lint:nobuild": "jasmine --config=lint/jasmine.json",
@@ -117,7 +116,6 @@
     "@terraformer/wkt": "^2.2.1",
     "altcha": "^0.9.0",
     "angulartics2": "^12.2.0",
-    "axios": "^1.11.0",
     "bootstrap": "^5.3",
     "cerialize": "0.1.18",
     "cli-progress": "^3.12.0",
@@ -226,7 +224,6 @@
     "karma-mocha-reporter": "2.2.5",
     "ng-mocks": "^14.13.5",
     "ngx-mask": "14.2.4",
-    "nodemon": "^2.0.22",
     "postcss": "^8.5",
     "postcss-import": "^14.0.0",
     "postcss-loader": "^4.0.3",

package.json

@@ -25,7 +25,6 @@ import * as ejs from 'ejs';
 import * as compression from 'compression';
 import expressStaticGzip from 'express-static-gzip';
 /* eslint-enable import/no-namespace */
-import axios from 'axios';
 import LRU from 'lru-cache';
 import { isbot } from 'isbot';
 import { createCertificate } from 'pem';
@@ -648,9 +647,9 @@ function isExcludedFromSsr(path: string, excludePathPattern: SsrExcludePatterns[
  */
 function healthCheck(req, res) {
   const baseUrl = `${REST_BASE_URL}${environment.actuators.endpointPath}`;
-  axios.get(baseUrl)
+  fetch(baseUrl)
     .then((response) => {
-      res.status(response.status).send(response.data);
+      res.status(response.status).send(response);
     })
     .catch((error) => {
       res.status(error.response.status).send({

server.ts

@@ -6,13 +6,14 @@
  * http://www.dspace.org/license/
  */
 
-import { XhrFactory } from '@angular/common';
-import { Injectable } from '@angular/core';
 import {
   Agent as HttpAgent,
   AgentOptions as HttpAgentOptions,
-} from 'http';
-import { Agent as HttpsAgent } from 'https';
+} from 'node:http';
+import { Agent as HttpsAgent } from 'node:https';
+
+import { XhrFactory } from '@angular/common';
+import { Injectable } from '@angular/core';
 import {
   prototype,
   XMLHttpRequest,

src/app/core/services/server-xhr.service.ts

@@ -8,7 +8,7 @@ import ITEMS from './data/items.json';
 import { fakeDataBase } from './db';
 
 const { Router } = require('express');
-const util = require('util');
+const util = require('node:util');
 
 // you would use cookies/token etc
 const USER_ID = 'f9d98cf1-1b96-464e-8755-bcc2a5c09077'; // hardcoded as an example