134770: Migrated @ngx-translate/core to standalone format

alexandrevryghem · alexandrevryghem · commit 166f1423b7fe · 2025-11-24T17:30:53.000+01:00
diff --git a/config/config.example.yml b/config/config.example.yml
@@ -235,8 +235,8 @@ submission:
           style: text-muted
           icon: fa-circle-xmark
 
-#  Default Language in which the UI will be rendered if the user's browser language is not an active language
-defaultLanguage: en
+#  Fallback language in which the UI will be rendered if the user's browser language is not an active language
+fallbackLanguage: en
 
 # Languages. DSpace Angular holds a message catalog for each of the following languages.
 # When set to active, users will be able to switch to the use of this language in the user interface.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -101,7 +101,7 @@
     "@ngrx/effects": "^19.2.1",
     "@ngrx/router-store": "^19.2.1",
     "@ngrx/store": "^19.2.1",
-    "@ngx-translate/core": "^16.0.3",
+    "@ngx-translate/core": "^17.0.0",
     "@nicky-lenaers/ngx-scroll-to": "^14.0.0",
     "@terraformer/wkt": "^2.2.1",
     "altcha": "^0.9.0",
diff --git a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.spec.ts b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.spec.ts
@@ -86,7 +86,7 @@ describe('LdnServiceFormEditComponent', () => {
     instant: () => 'translated-text',
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
-    onDefaultLangChange: new EventEmitter(),
+    onFallbackLangChange: new EventEmitter(),
   };
 
   beforeEach(async () => {
diff --git a/src/app/admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.spec.ts b/src/app/admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.spec.ts
@@ -44,7 +44,7 @@ describe('LdnServicesOverviewComponent', () => {
     get: () => of('translated-text'),
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
-    onDefaultLangChange: new EventEmitter(),
+    onFallbackLangChange: new EventEmitter(),
   };
 
   beforeEach(async () => {
diff --git a/src/app/admin/admin-notify-dashboard/admin-notify-detail-modal/admin-notify-detail-modal.component.ts b/src/app/admin/admin-notify-dashboard/admin-notify-detail-modal/admin-notify-detail-modal.component.ts
@@ -1,4 +1,3 @@
-
 import {
   Component,
   EventEmitter,
@@ -7,13 +6,9 @@ import {
 } from '@angular/core';
 import { AdminNotifyMessage } from '@dspace/core/coar-notify/notify-info/models/admin-notify-message.model';
 import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
-import {
-  TranslateModule,
-  TranslateService,
-} from '@ngx-translate/core';
+import { TranslatePipe } from '@ngx-translate/core';
 
 import { fadeIn } from '../../../shared/animations/fade';
-import { MissingTranslationHelper } from '../../../shared/translate/missing-translation.helper';
 
 @Component({
   selector: 'ds-admin-notify-detail-modal',
@@ -22,7 +17,7 @@ import { MissingTranslationHelper } from '../../../shared/translate/missing-tran
     fadeIn,
   ],
   imports: [
-    TranslateModule,
+    TranslatePipe,
   ],
 })
 /**
@@ -42,9 +37,9 @@ export class AdminNotifyDetailModalComponent {
   public isCoarMessageVisible = false;
 
 
-  constructor(protected activeModal: NgbActiveModal,
-              public translationsService: TranslateService) {
-    this.translationsService.missingTranslationHandler = new MissingTranslationHelper();
+  constructor(
+    protected activeModal: NgbActiveModal,
+  ) {
   }
 
 
diff --git a/src/app/collection-page/collection-item-mapper/collection-item-mapper.component.spec.ts b/src/app/collection-page/collection-item-mapper/collection-item-mapper.component.spec.ts
@@ -127,7 +127,7 @@ describe('CollectionItemMapperComponent', () => {
     get: () => of('test-message of collection ' + mockCollection.name),
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
-    onDefaultLangChange: new EventEmitter(),
+    onFallbackLangChange: new EventEmitter(),
   };
   const searchServiceStub = Object.assign(new SearchServiceStub(), {
     search: () => of(emptyList),
diff --git a/src/app/core/cookies/browser-orejime.service.spec.ts b/src/app/core/cookies/browser-orejime.service.spec.ts
@@ -87,7 +87,7 @@ describe('BrowserOrejimeService', () => {
         enablePrivacyStatement: true,
         enableCookieConsentPopup: true,
       },
-      defaultLanguage: 'en',
+      fallbackLanguage: 'en',
     };
 
     TestBed.configureTestingModule({
diff --git a/src/app/core/cookies/browser-orejime.service.ts b/src/app/core/cookies/browser-orejime.service.ts
@@ -164,7 +164,7 @@ export class BrowserOrejimeService extends OrejimeService {
       }),
     );
 
-    this.translateService.setDefaultLang(this.appConfig.defaultLanguage);
+    this.translateService.setFallbackLang(this.appConfig.fallbackLanguage);
 
     const user$: Observable<EPerson> = this.getUser$();
 
@@ -353,7 +353,7 @@ export class BrowserOrejimeService extends OrejimeService {
     /**
      * Make sure the fallback language is english
      */
-    this.translateService.setDefaultLang(this.appConfig.defaultLanguage);
+    this.translateService.setFallbackLang(this.appConfig.fallbackLanguage);
 
     this.translate(this.orejimeConfig.translations.zz);
   }
diff --git a/src/app/core/locale/locale.service.spec.ts b/src/app/core/locale/locale.service.spec.ts
@@ -25,7 +25,7 @@ import {
   LocaleService,
 } from './locale.service';
 
-describe('LocaleService test suite', () => {
+describe('LocaleService', () => {
   let service: LocaleService;
   let serviceAsAny: any;
   let cookieService: CookieService;
@@ -101,7 +101,7 @@ describe('LocaleService test suite', () => {
         { provide: AuthService, useValue: authService },
         { provide: RouteService, useValue: routeServiceStub },
         { provide: Document, useValue: document },
-        { provide: APP_CONFIG, useValue: { languages, defaultLanguage: 'en' } },
+        { provide: APP_CONFIG, useValue: { languages, fallbackLanguage: 'en' } },
         LocaleService,
       ],
     });
@@ -139,14 +139,14 @@ describe('LocaleService test suite', () => {
       });
     });
 
-    it('should return the default language if the cookie language is disabled', () => {
+    it('should return the fallback language if the cookie language is disabled', () => {
       spyOnGet.and.returnValue('disabled');
       testScheduler.run(({ expectObservable }) => {
         expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'en' });
       });
     });
 
-    it('should return the default language if the cookie language does not exist', () => {
+    it('should return the fallback language if the cookie language does not exist', () => {
       spyOnGet.and.returnValue('does-not-exist');
       testScheduler.run(({ expectObservable }) => {
         expectObservable(service.getCurrentLanguageCode()).toBe('(a|)', { a: 'en' });
@@ -179,15 +179,15 @@ describe('LocaleService test suite', () => {
       });
     });
 
-    it('should return default language list without user preferred language when no logged in user', () => {
+    it('should return fallback language list without user preferred language when no logged in user', () => {
       authService.isAuthenticated.and.returnValue(of(false));
       authService.isAuthenticationLoaded.and.returnValue(of(false));
       testScheduler.run(({ expectObservable }) => {
         expectObservable(service.getLanguageCodeList()).toBe('(a|)', { a: ['en-US;q=1', 'en;q=0.9'] });
       });
     });
 
-    it('should return default language list with user preferred language when user is logged in', () => {
+    it('should return fallback language list with user preferred language when user is logged in', () => {
       authService.isAuthenticated.and.returnValue(of(true));
       authService.isAuthenticationLoaded.and.returnValue(of(true));
       authService.getAuthenticatedUserFromStore.and.returnValue(of(EPersonMock2));
diff --git a/src/app/core/locale/locale.service.ts b/src/app/core/locale/locale.service.ts
@@ -87,7 +87,7 @@ export class LocaleService implements OnDestroy {
               .map(browserLang => browserLang.split(';')[0])
               .find(browserLang =>
                 this.translate.getLangs().some(userLang => userLang.toLowerCase() === browserLang.toLowerCase()),
-              ) || this.appConfig.defaultLanguage;
+              ) || this.appConfig.fallbackLanguage;
           }),
         );
     }
@@ -118,7 +118,7 @@ export class LocaleService implements OnDestroy {
                 languages.push(...this.setQuality(
                   [ePersonLang],
                   LANG_ORIGIN.EPERSON,
-                  !isEmpty(this.translate.currentLang)));
+                  !isEmpty(this.translate.getCurrentLang())));
               }
               return languages;
             }),
@@ -132,15 +132,15 @@ export class LocaleService implements OnDestroy {
             }
             if (this.translate.currentLang) {
               languages.push(...this.setQuality(
-                [this.translate.currentLang],
+                [this.translate.getCurrentLang()],
                 LANG_ORIGIN.UI,
                 false));
             }
             if (navigator.languages) {
               languages.push(...this.setQuality(
                 Object.assign([], navigator.languages),
                 LANG_ORIGIN.BROWSER,
-                !isEmpty(this.translate.currentLang)),
+                !isEmpty(this.translate.getCurrentLang())),
               );
             }
             return languages;
diff --git a/src/app/core/locale/server-locale.service.ts b/src/app/core/locale/server-locale.service.ts
@@ -73,7 +73,7 @@ export class ServerLocaleService extends LocaleService {
                 languages.push(...this.setQuality(
                   [ePersonLang],
                   LANG_ORIGIN.EPERSON,
-                  !isEmpty(this.translate.currentLang)));
+                  !isEmpty(this.translate.getCurrentLang())));
               }
               return languages;
             }),
@@ -82,9 +82,9 @@ export class ServerLocaleService extends LocaleService {
         return epersonLang$.pipe(
           map((epersonLang: string[]) => {
             const languages: string[] = [];
-            if (this.translate.currentLang) {
+            if (this.translate.getCurrentLang()) {
               languages.push(...this.setQuality(
-                [this.translate.currentLang],
+                [this.translate.getCurrentLang()],
                 LANG_ORIGIN.UI,
                 false));
             }
diff --git a/src/app/core/testing/translate.service.mock.ts b/src/app/core/testing/translate.service.mock.ts
@@ -5,6 +5,6 @@ export function getMockTranslateService(): TranslateService {
     get: jasmine.createSpy('get'),
     use: jasmine.createSpy('use'),
     instant: jasmine.createSpy('instant'),
-    setDefaultLang: jasmine.createSpy('setDefaultLang'),
+    setFallbackLang: jasmine.createSpy('setFallbackLang'),
   });
 }
diff --git a/src/app/entity-groups/research-entities/submission/item-list-elements/person/person-search-result-list-submission-element.component.spec.ts b/src/app/entity-groups/research-entities/submission/item-list-elements/person/person-search-result-list-submission-element.component.spec.ts
@@ -82,7 +82,7 @@ const translateServiceStub = {
   instant: (key) => key,
   onLangChange: new EventEmitter(),
   onTranslationChange: new EventEmitter(),
-  onDefaultLangChange: new EventEmitter(),
+  onFallbackLangChange: new EventEmitter(),
 };
 
 function init() {
diff --git a/src/app/external-log-in/email-confirmation/confirm-email/confirm-email.component.spec.ts b/src/app/external-log-in/email-confirmation/confirm-email/confirm-email.component.spec.ts
@@ -49,7 +49,7 @@ describe('ConfirmEmailComponent', () => {
     get: () => of(''),
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
-    onDefaultLangChange: new EventEmitter(),
+    onFallbackLangChange: new EventEmitter(),
   };
 
   beforeEach(async () => {
diff --git a/src/app/external-log-in/email-confirmation/confirmation-sent/confirmation-sent.component.spec.ts b/src/app/external-log-in/email-confirmation/confirmation-sent/confirmation-sent.component.spec.ts
@@ -27,7 +27,7 @@ describe('ConfirmationSentComponent', () => {
     instant: (key: any) => 'Mocked Translation Text',
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
-    onDefaultLangChange: new EventEmitter(),
+    onFallbackLangChange: new EventEmitter(),
   };
 
   beforeEach(async () => {
diff --git a/src/app/external-log-in/external-log-in/external-log-in.component.spec.ts b/src/app/external-log-in/external-log-in/external-log-in.component.spec.ts
@@ -76,7 +76,7 @@ describe('ExternalLogInComponent', () => {
     instant: (key: any) => 'Info Text',
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
-    onDefaultLangChange: new EventEmitter(),
+    onFallbackLangChange: new EventEmitter(),
   };
 
   beforeEach(async () => {
diff --git a/src/app/external-login-review-account-info-page/review-account-info/review-account-info.component.spec.ts b/src/app/external-login-review-account-info-page/review-account-info/review-account-info.component.spec.ts
@@ -54,7 +54,7 @@ describe('ReviewAccountInfoComponent', () => {
     get: () => of('test-message'),
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
-    onDefaultLangChange: new EventEmitter(),
+    onFallbackLangChange: new EventEmitter(),
   };
   const mockEPerson = EPersonMock;
   const modalStub = {
diff --git a/src/app/init.service.ts b/src/app/init.service.ts
@@ -189,8 +189,8 @@ export abstract class InitService {
         .map((a) => a.code),
     );
 
-    // Load the default language from the config file
-    // translate.setDefaultLang(environment.defaultLanguage);
+    // Load the fallback language from the config file
+    // translate.setFallbackLang(environment.fallbackLanguage);
 
     this.localeService.setCurrentLanguageCode();
   }
diff --git a/src/app/item-page/edit-item-page/item-collection-mapper/item-collection-mapper.component.spec.ts b/src/app/item-page/edit-item-page/item-collection-mapper/item-collection-mapper.component.spec.ts
@@ -122,7 +122,7 @@ describe('ItemCollectionMapperComponent', () => {
     get: () => of('test-message of item ' + mockItem.name),
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
-    onDefaultLangChange: new EventEmitter(),
+    onFallbackLangChange: new EventEmitter(),
   };
 
   const authorizationDataService = jasmine.createSpyObj('authorizationDataService', {
diff --git a/src/app/shared/access-control-form-container/item-access-control-select-bitstreams-modal/item-access-control-select-bitstreams-modal.component.spec.ts b/src/app/shared/access-control-form-container/item-access-control-select-bitstreams-modal/item-access-control-select-bitstreams-modal.component.spec.ts
@@ -44,7 +44,7 @@ describe('ItemAccessControlSelectBitstreamsModalComponent', () => {
     get: () => of('test-message'),
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
-    onDefaultLangChange: new EventEmitter(),
+    onFallbackLangChange: new EventEmitter(),
   };
 
   beforeEach(async () => {
diff --git a/src/app/shared/form/builder/ds-dynamic-form-ui/models/array-group/dynamic-form-array.component.spec.ts b/src/app/shared/form/builder/ds-dynamic-form-ui/models/array-group/dynamic-form-array.component.spec.ts
@@ -39,7 +39,7 @@ describe('DsDynamicFormArrayComponent', () => {
     instant: () => 'translated-text',
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
-    onDefaultLangChange: new EventEmitter(),
+    onFallbackLangChange: new EventEmitter(),
   };
 
   let component: DsDynamicFormArrayComponent;
diff --git a/src/app/shared/form/builder/ds-dynamic-form-ui/models/date-picker/date-picker.component.spec.ts b/src/app/shared/form/builder/ds-dynamic-form-ui/models/date-picker/date-picker.component.spec.ts
@@ -75,7 +75,7 @@ describe('DsDatePickerComponent test suite', () => {
       get: () => of('test-message'),
       onLangChange: new EventEmitter(),
       onTranslationChange: new EventEmitter(),
-      onDefaultLangChange: new EventEmitter(),
+      onFallbackLangChange: new EventEmitter(),
     };
 
     TestBed.configureTestingModule({
diff --git a/src/app/shared/lang-switch/lang-switch.component.html b/src/app/shared/lang-switch/lang-switch.component.html
@@ -19,8 +19,8 @@
              [lang]="lang"
              (keyup.enter)="useLang(lang)"
              (click)="useLang(lang)"
-             [attr.aria-selected]="lang === translate.currentLang"
-             [class.active]="lang === translate.currentLang">
+             [attr.aria-selected]="lang === translate.getCurrentLang()"
+             [class.active]="lang === translate.getCurrentLang()">
           {{ langLabel(lang) }}
         </div>
       }
diff --git a/src/app/shared/lang-switch/lang-switch.component.spec.ts b/src/app/shared/lang-switch/lang-switch.component.spec.ts
@@ -101,7 +101,7 @@ describe('LangSwitchComponent', () => {
         .then(() => {
           translate = TestBed.inject(TranslateService);
           translate.addLangs(mockConfig.languages.filter((langConfig: LangConfig) => langConfig.active === true).map((a) => a.code));
-          translate.setDefaultLang('en');
+          translate.setFallbackLang('en');
           translate.use('en');
           http = TestBed.inject(HttpTestingController);
           fixture = TestBed.createComponent(LangSwitchComponent);
@@ -147,7 +147,7 @@ describe('LangSwitchComponent', () => {
     });
   });
 
-  describe('with English as the only active and also default language', () => {
+  describe('with English as the only active and also fallback language', () => {
 
     let component: LangSwitchComponent;
     let fixture: ComponentFixture<LangSwitchComponent>;
@@ -185,7 +185,7 @@ describe('LangSwitchComponent', () => {
       }).compileComponents();
       translate = TestBed.inject(TranslateService);
       translate.addLangs(mockConfig.languages.filter((MyLangConfig) => MyLangConfig.active === true).map((a) => a.code));
-      translate.setDefaultLang('en');
+      translate.setFallbackLang('en');
       translate.use('en');
       http = TestBed.inject(HttpTestingController);
     }));
diff --git a/src/app/shared/lang-switch/lang-switch.component.ts b/src/app/shared/lang-switch/lang-switch.component.ts
@@ -55,7 +55,7 @@ export class LangSwitchComponent implements OnInit {
    * Returns the label for the current language
    */
   currentLangLabel(): string {
-    return this.activeLangs.find((MyLangConfig) => MyLangConfig.code === this.translate.currentLang).label;
+    return this.activeLangs.find((MyLangConfig) => MyLangConfig.code === this.translate.getCurrentLang()).label;
   }
 
   /**
diff --git a/src/app/workspaceitems-edit-page/workspaceitems-delete-page/workspaceitems-delete-page.component.spec.ts b/src/app/workspaceitems-edit-page/workspaceitems-delete-page/workspaceitems-delete-page.component.spec.ts
diff --git a/src/config/app-config.interface.ts b/src/config/app-config.interface.ts
diff --git a/src/config/default-app-config.ts b/src/config/default-app-config.ts
diff --git a/src/environments/environment.test.ts b/src/environments/environment.test.ts
diff --git a/src/main.server.ts b/src/main.server.ts
diff --git a/src/modules/app/browser-app.config.ts b/src/modules/app/browser-app.config.ts
diff --git a/src/modules/app/server-app.config.ts b/src/modules/app/server-app.config.ts
