Merge pull request #3650 from tdonohue/port_3225_to_8x

[Port dspace-8_x] Fixed headings by their rank

Author: tdonohue

src/app/collection-page/create-collection-page/create-collection-page.component.html

@@ -1,8 +1,8 @@
 <div class="container" *ngIf="(isLoading$ | async) === false">
   <div class="row">
     <div class="col-12 pb-4">
-      <h2 id="sub-header"
-          class="border-bottom pb-2">{{ 'collection.create.sub-head' | translate:{ parent: dsoNameService.getName((parentRD$| async)?.payload) } }}</h2>
+      <h1 id="sub-header"
+          class="border-bottom pb-2">{{ 'collection.create.sub-head' | translate:{ parent: dsoNameService.getName((parentRD$| async)?.payload) } }}</h1>
     </div>
   </div>
   <ds-collection-form (submitForm)="onSubmit($event)"

src/app/community-page/create-community-page/create-community-page.component.html

@@ -2,9 +2,9 @@
   <div class="row">
     <div class="col-12 pb-4">
       <ng-container *ngVar="(parentRD$ | async)?.payload as parent">
-        <h2 *ngIf="!parent" id="header" class="border-bottom p-2">{{ 'community.create.head' | translate }}</h2>
-        <h2 *ngIf="parent" id="sub-header"
-            class="border-bottom pb-2">{{ 'community.create.sub-head' | translate:{ parent: dsoNameService.getName(parent) } }}</h2>
+        <h1 *ngIf="!parent" id="header" class="border-bottom p-2">{{ 'community.create.head' | translate }}</h1>
+        <h1 *ngIf="parent" id="sub-header"
+            class="border-bottom pb-2">{{ 'community.create.sub-head' | translate:{ parent: dsoNameService.getName(parent) } }}</h1>
       </ng-container>
     </div>
   </div>

src/app/notifications/qa/events/quality-assurance-events.component.html

@@ -1,11 +1,11 @@
 <div class="container">
   <div class="row">
     <div class="col-12">
-      <h2 class="border-bottom pb-2">
+      <h1 class="border-bottom pb-2">
         <div class="d-flex justify-content-between">
           {{'notifications.events.title'| translate}}
         </div>
-      </h2>
+      </h1>
       <ds-alert *ngIf="!targetId"  [type]="'alert-info'">
         <span [innerHTML]="'quality-assurance.events.description' | translate : {topic: selectedTopicName, source: sourceId}"></span>
       </ds-alert>
@@ -17,9 +17,9 @@ <h2 class="border-bottom pb-2">
   </div>
   <div class="row">
     <div class="col-12">
-      <h4 class="border-bottom pb-2">
+      <h2 class="border-bottom pb-2">
         {{'quality-assurance.events.topic' | translate}} {{this.showTopic}}
-      </h4>
+      </h2>
 
       <ds-loading class="container" *ngIf="(isEventPageLoading | async)" message="{{'quality-assurance.loading' | translate}}"></ds-loading>
 
@@ -247,7 +247,7 @@ <h4 class="modal-title" id="acceptModal">{{'quality-assurance.event.sure' | tran
 
 <ng-template #ignoreModal let-modal>
   <div class="modal-header">
-    <h4 class="modal-title" id="ignoreModal">{{'quality-assurance.event.sure' | translate}}</h4>
+    <h1 class="modal-title h4" id="ignoreModal">{{'quality-assurance.event.sure' | translate}}</h1>
   </div>
   <div class="modal-body">
     <p>{{'quality-assurance.event.ignore.description' | translate}}</p>
@@ -264,7 +264,7 @@ <h4 class="modal-title" id="ignoreModal">{{'quality-assurance.event.sure' | tran
 
 <ng-template #rejectModal let-modal>
   <div class="modal-header">
-    <h4 class="modal-title" id="rejectModal">{{'quality-assurance.event.sure' | translate}}</h4>
+    <h1 class="modal-title h4" id="rejectModal">{{'quality-assurance.event.sure' | translate}}</h1>
   </div>
   <div class="modal-body">
     <p>{{'quality-assurance.event.reject.description' | translate}}</p>
@@ -281,7 +281,7 @@ <h4 class="modal-title" id="rejectModal">{{'quality-assurance.event.sure' | tran
 
 <ng-template #undoModal let-modal>
   <div class="modal-header">
-    <h4 class="modal-title" id="undoModal">{{'quality-assurance.event.sure' | translate}}</h4>
+    <h1 class="modal-title h4" id="undoModal">{{'quality-assurance.event.sure' | translate}}</h1>
   </div>
   <div class="modal-body">
     <p>{{'quality-assurance.event.undo.description' | translate}}</p>

src/app/notifications/qa/source/quality-assurance-source.component.html

@@ -1,13 +1,13 @@
 <div class="container">
     <div class="row">
       <div class="col-12">
-        <h2 class="border-bottom pb-2">{{'quality-assurance.title'| translate}}</h2>
+        <h1 class="border-bottom pb-2">{{'quality-assurance.title'| translate}}</h1>
         <ds-alert [type]="'alert-info'" [content]="'quality-assurance.source.description'"></ds-alert>
       </div>
     </div>
     <div class="row">
       <div class="col-12">
-        <h3 class="h4 border-bottom pb-2">{{'quality-assurance.source'| translate}}</h3>
+        <h2 class="h4 border-bottom pb-2">{{'quality-assurance.source'| translate}}</h2>
 
         <ds-loading class="container" *ngIf="(isSourceLoading() | async)" message="{{'quality-assurance.loading' | translate}}"></ds-loading>
         <ds-pagination *ngIf="(isSourceLoading() | async) !== true"

src/app/notifications/qa/topics/quality-assurance-topics.component.html

@@ -1,7 +1,7 @@
 <div class="container">
   <div class="row">
     <div class="col-12">
-      <h2 class="border-bottom pb-2">{{'quality-assurance.title'| translate}}</h2>
+      <h1 class="border-bottom pb-2">{{'quality-assurance.title'| translate}}</h1>
       <ds-alert *ngIf="!targetId" [type]="'alert-info'">{{'quality-assurance.topics.description'| translate:{source: sourceId} }}</ds-alert>
       <ds-alert *ngIf="targetId" [type]="'alert-info'">
         {{'quality-assurance.topics.description-with-target'| translate:{source: sourceId} }}
@@ -11,7 +11,7 @@ <h2 class="border-bottom pb-2">{{'quality-assurance.title'| translate}}</h2>
   </div>
   <div class="row">
     <div class="col-12">
-      <h4 class="border-bottom pb-2">{{'quality-assurance.topics'| translate}}</h4>
+      <h2 class="border-bottom pb-2">{{'quality-assurance.topics'| translate}}</h2>
 
       <ds-loading class="container" *ngIf="(isTopicsLoading() | async)" message="{{'quality-assurance.loading' | translate}}"></ds-loading>
       <ds-pagination *ngIf="(isTopicsLoading() | async) !== true"

src/app/shared/mydspace-actions/workspaceitem/workspaceitem-actions.component.html

@@ -30,7 +30,7 @@
 
 <ng-template #content let-c="close" let-d="dismiss">
   <div class="modal-header">
-    <h4 class="modal-title text-danger">{{'submission.general.discard.confirm.title' | translate}}</h4>
+    <div class="modal-title text-danger h4">{{'submission.general.discard.confirm.title' | translate}}</div>
     <button type="button" id="delete_close" class="close" aria-label="Close" (click)="d('cancel')">
       <span aria-hidden="true">&times;</span>
     </button>

src/app/shared/object-list/my-dspace-result-list-element/item-list-preview/item-list-preview.component.html

@@ -9,7 +9,7 @@
         <ds-badges [object]="item" [context]="badgeContext" [showAccessStatus]="true"></ds-badges>
       </div>
       <ds-truncatable [id]="item.id">
-        <h3 [innerHTML]="dsoTitle" [ngClass]="{'lead': true,'text-muted': !item.firstMetadataValue('dc.title')}"></h3>
+        <h2 [innerHTML]="dsoTitle" [ngClass]="{'lead': true,'text-muted': !item.firstMetadataValue('dc.title')}"></h2>
         <div>
           <span class="text-muted">
             <ds-truncatable-part [id]="item.id" [minLines]="1">

src/app/shared/search-form/scope-selector-modal/scope-selector-modal.component.html

@@ -6,14 +6,14 @@
     </div>
     <div class="modal-body">
         <button class="btn btn-outline-primary btn-lg btn-block" (click)="selectObject(undefined)">{{'dso-selector.' + action + '.' + objectType.toString().toLowerCase() + '.button'| translate }}</button>
-        <h3 class="position-relative py-1 my-3 font-weight-normal">
+        <div class="position-relative py-1 my-3 font-weight-normal h3">
             <hr>
             <div id="create-community-or-separator" class="text-center position-absolute w-100">
                 <span class="px-4 bg-white">{{'dso-selector.' + action + '.' + objectType.toString().toLowerCase() + '.or-divider' | translate}}</span>
             </div>
-        </h3>
+        </div>
 
-        <h5 class="px-2">{{'dso-selector.' + action + '.' + objectType.toString().toLowerCase() + '.input-header' | translate}}</h5>
+        <h2 class="px-2 h5">{{'dso-selector.' + action + '.' + objectType.toString().toLowerCase() + '.input-header' | translate}}</h2>
         <ds-dso-selector [currentDSOId]="dsoRD?.payload.uuid" [types]="selectorTypes" [sort]="defaultSort" (onSelect)="selectObject($event)"></ds-dso-selector>
     </div>
 </div>

src/app/shared/search/search-results/search-results.component.html

@@ -1,5 +1,5 @@
 <div class="d-flex justify-content-between">
-    <h2 *ngIf="!disableHeader">{{ (configuration ? configuration + '.search.results.head' : 'search.results.head') | translate }}</h2>
+    <h1 *ngIf="!disableHeader">{{ (configuration ? configuration + '.search.results.head' : 'search.results.head') | translate }}</h1>
     <ds-search-export-csv *ngIf="showCsvExport" [searchConfig]="searchConfig"></ds-search-export-csv>
 </div>
 <div *ngIf="searchResults && searchResults?.hasSucceeded && !searchResults?.isLoading && searchResults?.payload?.page.length > 0" @fadeIn>

src/app/submission/sections/upload/section-upload.component.html

@@ -51,7 +51,7 @@
 <ng-template #noFileUploaded>
   <div class="row">
     <div class="col-md-12">
-      <h3 class="text-center"><span class="text-muted">{{'submission.sections.upload.no-file-uploaded' | translate}}</span></h3>
+      <div class="text-center h3"><span class="text-muted">{{'submission.sections.upload.no-file-uploaded' | translate}}</span></div>
     </div>
   </div>
 </ng-template>