Skip to content

Commit 3ab9f6a

Browse files
authored
Merge pull request #2771 from saschaszott/patch-14
Layout improvement in feedback form page
2 parents a7e4f7d + b67801f commit 3ab9f6a

File tree

1 file changed

+19
-13
lines changed

1 file changed

+19
-13
lines changed

src/app/info/feedback/feedback-form/feedback-form.component.html

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,37 +3,43 @@
33
<h1>{{ 'info.feedback.head' | translate }}</h1>
44
<p>{{ 'info.feedback.info' | translate }}</p>
55
<form [formGroup]="feedbackForm" (ngSubmit)="createFeedback()" class="col p-0">
6-
<div class="row">
6+
<div class="row mt-3">
77
<div class="control-group col-sm-12">
88
<label class="control-label" for="email">{{ 'info.feedback.email-label' | translate }}&nbsp;</label>
99
<input id="email" class="form-control" name="email" type="text" value="" formControlName="email" autofocus="autofocus" title="{{ 'info.feedback.email_help' | translate }}">
1010
<small class="text-muted">{{ 'info.feedback.email_help' | translate }}</small>
1111
</div>
1212
</div>
1313

14-
<ng-container *ngIf="feedbackForm.controls.email.invalid && (feedbackForm.controls.email.dirty || feedbackForm.controls.email.touched)"
15-
class="alert">
16-
<ds-error *ngIf="feedbackForm.controls.email.errors?.required" message="{{'info.feedback.error.email.required' | translate}}"></ds-error>
17-
<ds-error *ngIf="feedbackForm.controls.email.errors?.pattern" message="{{'info.feedback.error.email.required' | translate}}"></ds-error>
18-
</ng-container>
19-
<div class="row">
14+
<div *ngIf="feedbackForm.controls.email.invalid && (feedbackForm.controls.email.dirty || feedbackForm.controls.email.touched)" class="row">
15+
<div class="col-sm-12 alert">
16+
<ds-error *ngIf="feedbackForm.controls.email.errors?.required" message="{{'info.feedback.error.email.required' | translate}}"></ds-error>
17+
<ds-error *ngIf="feedbackForm.controls.email.errors?.pattern" message="{{'info.feedback.error.email.required' | translate}}"></ds-error>
18+
</div>
19+
</div>
20+
21+
<div class="row mt-3">
2022
<div class="control-group col-sm-12">
2123
<label class="control-label" for="comments">{{ 'info.feedback.comments' | translate }}:&nbsp;</label>
2224
<textarea id="comments" formControlName="message" class="form-control" name="message" cols="20" rows="5"> </textarea>
2325
</div>
2426
</div>
25-
<ng-container *ngIf="feedbackForm.controls.message.invalid && (feedbackForm.controls.message.dirty || feedbackForm.controls.message.touched)"
26-
class="alert">
27-
<ds-error *ngIf="feedbackForm.controls.message.errors?.required" message="{{'info.feedback.error.message.required' | translate}}"></ds-error>
28-
</ng-container>
29-
<div class="row">
27+
28+
<div *ngIf="feedbackForm.controls.message.invalid && (feedbackForm.controls.message.dirty || feedbackForm.controls.message.touched)" class="row">
29+
<div class="col-sm-12 alert">
30+
<ds-error *ngIf="feedbackForm.controls.message.errors?.required" message="{{'info.feedback.error.message.required' | translate}}"></ds-error>
31+
</div>
32+
</div>
33+
34+
<div class="row mt-3">
3035
<div class="control-group col-sm-12">
3136
<label class="control-label" for="page">{{ 'info.feedback.page-label' | translate }}&nbsp;</label>
3237
<input id="page" readonly class="form-control" name="page" type="text" value="" formControlName="page" autofocus="autofocus" title="{{ 'info.feedback.page_help' | translate }}">
3338
<small class="text-muted">{{ 'info.feedback.page_help' | translate }}</small>
3439
</div>
3540
</div>
36-
<div class="row py-2">
41+
42+
<div class="row mt-3">
3743
<div class="control-group col-sm-12 text-right">
3844
<button [disabled]="!feedbackForm.valid" class="btn btn-primary" name="submit" type="submit">{{ 'info.feedback.send' | translate }}</button>
3945
</div>

0 commit comments

Comments
 (0)