DURACOM-393 Review fixes

Author: Mattia Vianelli

src/app/item-page/simple/field-components/specific-field/orcid/item-page-orcid-field.component.html

@@ -2,7 +2,7 @@
   <div class="item-page-field mb-2">
     <label class="font-weight-bold">{{ label | translate }}</label>
     <a [href]="orcidUrl$ | async" target="_blank" rel="noopener noreferrer" class="d-flex align-items-center">
-      <img [src]="img.URI" [alt]="img.alt | translate" [style]="'height: var(' + img.heightVar + ', 16px); margin-right: 8px;'" />
+      <img [src]="img.URI" [alt]="img.alt | translate" class="orcid-icon" />
       <span>{{ orcidId }}</span>
     </a>
   </div>

src/app/item-page/simple/field-components/specific-field/orcid/item-page-orcid-field.component.scss

@@ -0,0 +1,4 @@
+.orcid-icon {
+  height: var(--ds-orcid-icon-height, 16px);
+  margin-right: 8px;
+}

src/app/item-page/simple/field-components/specific-field/orcid/item-page-orcid-field.component.spec.ts

@@ -5,14 +5,14 @@ import {
 } from '@angular/core/testing';
 import { TranslateModule } from '@ngx-translate/core';
 import { of } from 'rxjs';
+import { APP_CONFIG } from 'src/config/app-config.interface';
 
 import { BrowseService } from '../../../../../core/browse/browse.service';
 import { BrowseDefinitionDataService } from '../../../../../core/browse/browse-definition-data.service';
 import { ConfigurationDataService } from '../../../../../core/data/configuration-data.service';
 import { ConfigurationProperty } from '../../../../../core/shared/configuration-property.model';
 import { Item } from '../../../../../core/shared/item.model';
 import { createSuccessfulRemoteDataObject$ } from '../../../../../shared/remote-data.utils';
-import { APP_CONFIG } from 'src/config/app-config.interface';
 import { ItemPageOrcidFieldComponent } from './item-page-orcid-field.component';
 
 describe('ItemPageOrcidFieldComponent', () => {
@@ -102,6 +102,17 @@ describe('ItemPageOrcidFieldComponent', () => {
     expect(component.hasOrcid()).toBe(false);
   });
 
+  it('should set hasOrcidMetadata property on init', () => {
+    fixture.detectChanges();
+    expect(component.hasOrcidMetadata).toBe(true);
+  });
+
+  it('should set hasOrcidMetadata to false when item has no ORCID', () => {
+    component.item = Object.assign(new Item(), { metadata: {} });
+    component.ngOnInit();
+    expect(component.hasOrcidMetadata).toBe(false);
+  });
+
   it('should construct ORCID URL on init', (done) => {
     fixture.detectChanges();
 
@@ -111,13 +122,9 @@ describe('ItemPageOrcidFieldComponent', () => {
     });
   });
 
-  it('should extract ORCID ID on init', (done) => {
+  it('should extract ORCID ID on init', () => {
     fixture.detectChanges();
-
-    component.orcidId$.subscribe(id => {
-      expect(id).toBe('0000-0002-1825-0097');
-      done();
-    });
+    expect(component.orcidId).toBe('0000-0002-1825-0097');
   });
 
   it('should handle ORCID with leading slash', (done) => {
@@ -138,6 +145,8 @@ describe('ItemPageOrcidFieldComponent', () => {
     component.ngOnInit();
     fixture.detectChanges();
 
+    expect(component.orcidId).toBe('0000-0002-1825-0097');
+
     component.orcidUrl$.subscribe(url => {
       expect(url).toBe('https://sandbox.orcid.org/0000-0002-1825-0097');
       done();
@@ -149,6 +158,8 @@ describe('ItemPageOrcidFieldComponent', () => {
     component.ngOnInit();
     fixture.detectChanges();
 
+    expect(component.orcidId).toBeNull();
+
     component.orcidUrl$.subscribe(url => {
       expect(url).toBeNull();
       done();

src/app/item-page/simple/field-components/specific-field/orcid/item-page-orcid-field.component.ts

@@ -24,6 +24,7 @@ import { ItemPageFieldComponent } from '../item-page-field.component';
 @Component({
   selector: 'ds-item-page-orcid-field',
   templateUrl: './item-page-orcid-field.component.html',
+  styleUrls: ['./item-page-orcid-field.component.scss'],
   standalone: true,
   imports: [
     AsyncPipe,